Re: [PATCH 0/4] x86/module: Out-of-tree module decode and sanitize

Peter Zijlstra
2020-04-07T20:48:47Z

On Tue, Apr 07, 2020 at 09:21:31PM +0100, Andrew Cooper wrote:
> > + switch (insn->opcode.bytes[1]) {
> > + case 0x00:
> > + if (modrm_mod != 0x03)
> > + break;
> > +
>
> Apologies - missed this before.  LLDT and LTR can be encoded with a
> memory operand, so you need to drop the modrm_mod check to spot all
> instances.

I spotted the same, already fixed. Sorry for the mistake, reading opcode
tables it a pain at the best of times :/