From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B12BC00523 for ; Wed, 8 Jan 2020 09:43:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 290582072A for ; Wed, 8 Jan 2020 09:43:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726823AbgAHJnJ (ORCPT ); Wed, 8 Jan 2020 04:43:09 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:43715 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726098AbgAHJnJ (ORCPT ); Wed, 8 Jan 2020 04:43:09 -0500 X-Originating-IP: 90.65.102.129 Received: from localhost (lfbn-lyo-1-1670-129.w90-65.abo.wanadoo.fr [90.65.102.129]) (Authenticated sender: gregory.clement@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id A72C020007; Wed, 8 Jan 2020 09:43:04 +0000 (UTC) From: Gregory CLEMENT To: Yangtao Li , jassisinghbrar@gmail.com, nsaenzjulienne@suse.de, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, lftan@altera.com, matthias.bgg@gmail.com, agross@kernel.org, bjorn.andersson@linaro.org, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, thierry.reding@gmail.com, jonathanh@nvidia.com, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, nios2-dev@lists.rocketboards.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org Cc: Yangtao Li Subject: Re: [PATCH 13/13] mailbox: armada-37xx-rwtm: convert to devm_platform_ioremap_resource In-Reply-To: <20191228183538.26189-13-tiny.windzz@gmail.com> References: <20191228183538.26189-1-tiny.windzz@gmail.com> <20191228183538.26189-13-tiny.windzz@gmail.com> Date: Wed, 08 Jan 2020 10:43:04 +0100 Message-ID: <87imlmb7x3.fsf@FE-laptop> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yangtao Li, > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Applied on mvebu/drivers Thanks, Gregory > --- > drivers/mailbox/armada-37xx-rwtm-mailbox.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/mailbox/armada-37xx-rwtm-mailbox.c b/drivers/mailbox/armada-37xx-rwtm-mailbox.c > index 19f086716dc5..02b7b28e6969 100644 > --- a/drivers/mailbox/armada-37xx-rwtm-mailbox.c > +++ b/drivers/mailbox/armada-37xx-rwtm-mailbox.c > @@ -143,7 +143,6 @@ static const struct mbox_chan_ops a37xx_mbox_ops = { > static int armada_37xx_mbox_probe(struct platform_device *pdev) > { > struct a37xx_mbox *mbox; > - struct resource *regs; > struct mbox_chan *chans; > int ret; > > @@ -156,9 +155,7 @@ static int armada_37xx_mbox_probe(struct platform_device *pdev) > if (!chans) > return -ENOMEM; > > - regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - > - mbox->base = devm_ioremap_resource(&pdev->dev, regs); > + mbox->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(mbox->base)) { > dev_err(&pdev->dev, "ioremap failed\n"); > return PTR_ERR(mbox->base); > -- > 2.17.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com