Re: [PATCH v1 2/2] signal: add procfd_signal() syscall

Joey Pabalinas
2018-11-28T23:02:11Z

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

On Wed, Nov 28, 2018 at 11:05:49PM +0100, Christian Brauner wrote:
> On Wed, Nov 28, 2018 at 11:45:34AM -1000, Joey Pabalinas wrote:
> > On Mon, Nov 19, 2018 at 11:32:39AM +0100, Christian Brauner wrote:
> > > + if (info) {
> > > + ret = __copy_siginfo_from_user(sig, &kinfo, info);
> > > + if (unlikely(ret))
> > > + goto err;
> >
>
> I think you're misreading here. It jumps to:
>
> err:
> fdput(f);
> return ret;
>
> and does propagate the error. This is also an old iteration of the patch.

Whoops, that I am. Sorry about that.

--
Cheers,
Joey Pabalinas

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]