From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FF44C6778A for ; Sun, 22 Jul 2018 13:58:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18ACE20875 for ; Sun, 22 Jul 2018 13:58:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18ACE20875 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=users.sourceforge.jp Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728916AbeGVOy6 (ORCPT ); Sun, 22 Jul 2018 10:54:58 -0400 Received: from mail02.asahi-net.or.jp ([202.224.55.14]:41431 "EHLO mail02.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728730AbeGVOy6 (ORCPT ); Sun, 22 Jul 2018 10:54:58 -0400 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.vps.ablenet.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail02.asahi-net.or.jp (Postfix) with ESMTPA id 58137F7F0E; Sun, 22 Jul 2018 22:58:08 +0900 (JST) Received: from yo-satoh-debian.ysato.ml (ZM028236.ppp.dion.ne.jp [222.8.28.236]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id E2B2724006D; Sun, 22 Jul 2018 22:58:07 +0900 (JST) Date: Sun, 22 Jul 2018 22:58:07 +0900 Message-ID: <87in57fk40.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Will Deacon Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@kernel.org, linux-arm-kernel@lists.infradead.org, yamada.masahiro@socionext.com Subject: Re: [PATCH 1/9] h8300: Don't include linux/kernel.h in asm/atomic.h In-Reply-To: <1527159586-8578-2-git-send-email-will.deacon@arm.com> References: <1527159586-8578-1-git-send-email-will.deacon@arm.com> <1527159586-8578-2-git-send-email-will.deacon@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 May 2018 19:59:38 +0900, Will Deacon wrote: > > linux/kernel.h isn't needed by asm/atomic.h and will result in circular > dependencies when the asm-generic atomic bitops are built around the > tomic_long_t interface. > > Remove the broad include and replace it with linux/compiler.h for > READ_ONCE etc and asm/irqflags.h for arch_local_irq_save etc. > > Cc: Yoshinori Sato > Signed-off-by: Will Deacon > --- > arch/h8300/include/asm/atomic.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/h8300/include/asm/atomic.h b/arch/h8300/include/asm/atomic.h > index 941e7554e886..b174dec099bf 100644 > --- a/arch/h8300/include/asm/atomic.h > +++ b/arch/h8300/include/asm/atomic.h > @@ -2,8 +2,10 @@ > #ifndef __ARCH_H8300_ATOMIC__ > #define __ARCH_H8300_ATOMIC__ > > +#include > #include > #include > +#include > > /* > * Atomic operations that C can't guarantee us. Useful for > @@ -15,8 +17,6 @@ > #define atomic_read(v) READ_ONCE((v)->counter) > #define atomic_set(v, i) WRITE_ONCE(((v)->counter), (i)) > > -#include > - > #define ATOMIC_OP_RETURN(op, c_op) \ > static inline int atomic_##op##_return(int i, atomic_t *v) \ > { \ > -- > 2.1.4 > Sorry too late reply. Applied to h8300-next. Thanks. -- Yosinori Sato