* [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type
@ 2018-04-24 13:14 Luc Van Oostenryck
2018-04-24 15:11 ` Jani Nikula
0 siblings, 1 reply; 2+ messages in thread
From: Luc Van Oostenryck @ 2018-04-24 13:14 UTC (permalink / raw)
To: linux-kernel
Cc: Luc Van Oostenryck, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
David Airlie, intel-gfx, dri-devel
All implementations of the method intel_dvo_dev_ops::mode_valid(), as
well as the underlying struct drm_connector_helper_funcs::mode_valid()
use 'enum drm_mode_status' for the method's return type but the
declaration of intel_dvo_dev_ops::mode_valid() uses an 'int' for it.
Fix this by using 'enum drm_mode_status' for the declaration too.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
drivers/gpu/drm/i915/dvo.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/dvo.h b/drivers/gpu/drm/i915/dvo.h
index 5e6a3013d..b6e143ebc 100644
--- a/drivers/gpu/drm/i915/dvo.h
+++ b/drivers/gpu/drm/i915/dvo.h
@@ -74,7 +74,7 @@ struct intel_dvo_dev_ops {
*
* \return MODE_OK if the mode is valid, or another MODE_* otherwise.
*/
- int (*mode_valid)(struct intel_dvo_device *dvo,
+ enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
struct drm_display_mode *mode);
/*
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type
2018-04-24 13:14 [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type Luc Van Oostenryck
@ 2018-04-24 15:11 ` Jani Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2018-04-24 15:11 UTC (permalink / raw)
To: Luc Van Oostenryck, linux-kernel
Cc: Luc Van Oostenryck, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
intel-gfx, dri-devel
On Tue, 24 Apr 2018, Luc Van Oostenryck <luc.vanoostenryck@gmail.com> wrote:
> All implementations of the method intel_dvo_dev_ops::mode_valid(), as
> well as the underlying struct drm_connector_helper_funcs::mode_valid()
> use 'enum drm_mode_status' for the method's return type but the
> declaration of intel_dvo_dev_ops::mode_valid() uses an 'int' for it.
>
> Fix this by using 'enum drm_mode_status' for the declaration too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
> drivers/gpu/drm/i915/dvo.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/dvo.h b/drivers/gpu/drm/i915/dvo.h
> index 5e6a3013d..b6e143ebc 100644
> --- a/drivers/gpu/drm/i915/dvo.h
> +++ b/drivers/gpu/drm/i915/dvo.h
> @@ -74,7 +74,7 @@ struct intel_dvo_dev_ops {
> *
> * \return MODE_OK if the mode is valid, or another MODE_* otherwise.
> */
> - int (*mode_valid)(struct intel_dvo_device *dvo,
> + enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
> struct drm_display_mode *mode);
Please adjust the alignment here as well. With that,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Oh, and as far as lists go, intel-gfx is sufficient.
>
> /*
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-24 15:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-24 13:14 [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type Luc Van Oostenryck
2018-04-24 15:11 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).