From: Michael Ellerman <mpe@ellerman.id.au>
To: Andi Kleen <andi@firstfloor.org>, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] Support resetting WARN*_ONCE
Date: Wed, 18 Oct 2017 16:35:14 +1100 [thread overview]
Message-ID: <87infdhvcd.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20171017214017.22708-1-andi@firstfloor.org>
Andi Kleen <andi@firstfloor.org> writes:
> From: Andi Kleen <ak@linux.intel.com>
>
> I like _ONCE warnings because it's guaranteed that they don't
> flood the log.
>
> During testing I find it useful to reset the state of the once warnings,
> so that I can rerun tests and see if they trigger again, or can
> guarantee that a test run always hits the same warnings.
>
> This patch adds a debugfs interface to reset all the _ONCE
> warnings so that they appear again:
>
> echo 1 > /sys/kernel/debug/clear_warn_once
>
> This is implemented by putting all the warning booleans into
> a special section, and clearing it.
That won't work for arches that do the ONCE logic with a flag will it?
ie. arm64, parisc, powerpc, s390, sh, x86.
They use the version of WARN_ON_ONCE at line ~64 of bug.h
#define __WARN_ONCE_TAINT(taint) __WARN_FLAGS(BUGFLAG_ONCE|BUGFLAG_TAINT(taint))
#define WARN_ON_ONCE(condition) ({ \
int __ret_warn_on = !!(condition); \
if (unlikely(__ret_warn_on)) \
__WARN_ONCE_TAINT(TAINT_WARN); \
unlikely(__ret_warn_on); \
})
cheers
> diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
> index 87191357d303..68c2f08b7914 100644
> --- a/include/asm-generic/bug.h
> +++ b/include/asm-generic/bug.h
> @@ -129,7 +129,7 @@ void __warn(const char *file, int line, void *caller, unsigned taint,
>
> #ifndef WARN_ON_ONCE
> #define WARN_ON_ONCE(condition) ({ \
> - static bool __section(.data.unlikely) __warned; \
> + static bool __section(.data.once) __warned; \
> int __ret_warn_once = !!(condition); \
> \
> if (unlikely(__ret_warn_once && !__warned)) { \
> @@ -141,7 +141,7 @@ void __warn(const char *file, int line, void *caller, unsigned taint,
> #endif
>
> #define WARN_ONCE(condition, format...) ({ \
> - static bool __section(.data.unlikely) __warned; \
> + static bool __section(.data.once) __warned; \
> int __ret_warn_once = !!(condition); \
> \
> if (unlikely(__ret_warn_once && !__warned)) { \
> @@ -152,7 +152,7 @@ void __warn(const char *file, int line, void *caller, unsigned taint,
> })
>
> #define WARN_TAINT_ONCE(condition, taint, format...) ({ \
> - static bool __section(.data.unlikely) __warned; \
> + static bool __section(.data.once) __warned; \
> int __ret_warn_once = !!(condition); \
> \
> if (unlikely(__ret_warn_once && !__warned)) { \
next prev parent reply other threads:[~2017-10-18 5:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 21:40 [PATCH] Support resetting WARN*_ONCE Andi Kleen
2017-10-17 21:54 ` Andrew Morton
2017-10-17 22:11 ` Andi Kleen
2017-10-18 5:35 ` Michael Ellerman [this message]
2017-10-19 20:47 ` Andi Kleen
2017-11-03 9:39 ` Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2016-08-02 20:40 Andi Kleen
2016-08-03 4:12 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87infdhvcd.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox