From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754168AbdBHMIR (ORCPT ); Wed, 8 Feb 2017 07:08:17 -0500 Received: from mga06.intel.com ([134.134.136.31]:10291 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753599AbdBHMIQ (ORCPT ); Wed, 8 Feb 2017 07:08:16 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,346,1477983600"; d="asc'?scan'208";a="222776038" From: Felipe Balbi To: "Gustavo A. R. Silva" Cc: gregkh@linuxfoundation.org, bhumirks@gmail.com, mina86@mina86.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drivers: usb: gadget: udc: add missing break in switch In-Reply-To: <20170208040243.Horde.88jNxPiVAcL_hzrlS8ZVsGy@gator4166.hostgator.com> References: <20170208072212.GA8209@embeddedgus> <87mvdxxchc.fsf@linux.intel.com> <20170208040243.Horde.88jNxPiVAcL_hzrlS8ZVsGy@gator4166.hostgator.com> Date: Wed, 08 Feb 2017 14:05:35 +0200 Message-ID: <87inokyjjk.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, "Gustavo A. R. Silva" writes: >> "Gustavo A. R. Silva" writes: >>> Add missing break in switch. >>> >>> Addresses-Coverity-ID: 201385 >>> Signed-off-by: Gustavo A. R. Silva >>> --- >>> drivers/usb/gadget/udc/mv_udc_core.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/usb/gadget/udc/mv_udc_core.c=20=20 >>> b/drivers/usb/gadget/udc/mv_udc_core.c >>> index 27ebb0d..56b3574 100644 >>> --- a/drivers/usb/gadget/udc/mv_udc_core.c >>> +++ b/drivers/usb/gadget/udc/mv_udc_core.c >>> @@ -489,6 +489,7 @@ static int mv_ep_enable(struct usb_ep *_ep, >>> break; >>> case USB_ENDPOINT_XFER_CONTROL: >>> ios =3D 1; >>> + break; >> >> are you SURE this is supposed to have this break statement? What if we >> want to initialize mult to 0 *also* for control endpoints? How did you >> test this? Do you have access to Marvel's documentation for this >> controller? >> > > Certainly I wasn't sure, but I also think this is kind of obscure=20=20 > code. If that is the case that we also want to initialize mult to 0,=20=20 > wouldn't it be clearer (for maintenance purposes) to add mult =3D 0 and= =20=20 > the break statement after ios =3D 1? > > What do you think if I modify that piece of code as follows: I think you need to test it, or get someone to test it for you :-) =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlibCY8ACgkQzL64meEa mQYWexAAlYXjkQZYtFKL525PRfQn1Co7+taNb3UY4i/eXq7CtQhJ402txLhGM0YQ 4lM53CnhLgYt2HRW6TIfbq45qDSjztPjMWU8jme5BlXyKTouCrLpk1G9ukOYiend E9YdmjMrXQv7aN2aVSmfrso+KSgUCaxoTTPMjlC0VnoM6nrnRJMBE17yg3gZ/1cA ELsa1B6yOO+s9NWMu9jRzbFcuTwsCuTF5zsBmyrjXYY176Vj6GGd+nTN9UdxJV3Q IrS/CGKcID4n5y7MyqJUt8jBtTaCxm89WBqTm1F7BvA3ipHeNFlw+m9vjlrq8toc O6wJFujcVf7cXmPl+3ESsQdTLLJqx5X1B427BSAhlZJ9Vy3AjNCgJchILCIGd/++ fWA61cfDH5kZ4B1tgi6pfhGEJeLFCIuvJLVIZwZgGCEnzaNR4cFt/ccnknG43Vst W6sVT+x5PmKKQ0xkaGDLYDy1Ohb13diZmuaUO66bA41BGbX2VdnrRkf12oUGTd0F cuLJ/jM8CSVQACg0GweYYjXpepNoDS1ZWUIcm7/mEbSjuIE7u3sKPfjI3u+lPH56 PA0YE/XBUfZ7i7KD6D4y9HhCv+0H7EkUkf+GWFDwYp8r2R/bz9U+YV48BL1IQbPv so5KB9wQrUAF+4qPBmjS/xoennhFpecVuapvlbl7MiQ3nsMdK1o= =VdQ6 -----END PGP SIGNATURE----- --=-=-=--