From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753827AbcHRM0K (ORCPT ); Thu, 18 Aug 2016 08:26:10 -0400 Received: from mga01.intel.com ([192.55.52.88]:56061 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752911AbcHRM0I (ORCPT ); Thu, 18 Aug 2016 08:26:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,539,1464678000"; d="asc'?scan'208";a="1043453751" From: Felipe Balbi To: Baolin Wang Cc: Greg KH , mathias.nyman@intel.com, USB , LKML , Mark Brown Subject: Re: [PATCH 2/4] usb: host: xhci: Introduce one new 'usb3_slow_suspend' member for xhci private data In-Reply-To: References: <87inuy5yvr.fsf@linux.intel.com> User-Agent: Notmuch/0.22.1+63~g994277e (https://notmuchmail.org) Emacs/25.1.1 (x86_64-pc-linux-gnu) Date: Thu, 18 Aug 2016 15:25:11 +0300 Message-ID: <87inuy463c.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Baolin Wang writes: > Hi Felipe, > > On 18 August 2016 at 15:18, Felipe Balbi wrote: >> >> Hi, >> >> Baolin Wang writes: >>> Now some usb controllers (such as dwc3 controller) need 'XHCI_SLOW_SUSP= END' >>> quirk when suspending the xhci, thus we need to add 'usb3_slow_suspend'= member >>> in xhci platform data to support this. >>> >>> Signed-off-by: Baolin Wang >>> --- >>> drivers/usb/host/xhci-plat.c | 3 +++ >>> include/linux/usb/xhci_pdriver.h | 3 +++ >>> 2 files changed, 6 insertions(+) >>> >>> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c >>> index e2e2487..162f17c 100644 >>> --- a/drivers/usb/host/xhci-plat.c >>> +++ b/drivers/usb/host/xhci-plat.c >>> @@ -250,6 +250,9 @@ static int xhci_plat_probe(struct platform_device *= pdev) >>> (pdata && pdata->usb3_lpm_capable)) >>> xhci->quirks |=3D XHCI_LPM_SUPPORT; >>> >>> + if (pdata && pdata->usb3_slow_suspend) >>> + xhci->quirks |=3D XHCI_SLOW_SUSPEND; >> >> I remember having a discussion about this with Paul Z and it turned out >> that we really didn't need SLOW_SUSPEND. Can you describe further in >> what situation you need this quirk? > > On my dwc3 platform, xhci suspend will be failed if we have not > enabled XHCI_SLOW_SUSPEND quirk. fail how? What error do you see? Do you have some traces of what's happening? Did you try figuring out if this is, perhaps, caused by some call ordering which is wrong? Perhaps disabling PHYs too early or something like that? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJXtaknAAoJEIaOsuA1yqREfcIP/jdM0b+p6eu5V8xxfiMgS5pG p0qkbkh0i964RHLEQwhlgTqn0OLPsPnssvRrz9ufHVIsd3nIgsqelqTOxh83ZN82 VhvFRqa6ezo1RgfSa6VvDo9S65UPQOWFvGMcEsAHaeeaV676U+gr+3u3sGVwVOJE 8fj3lmOgrIx+Dbsv6xbP1o+DhpZGX8tCUODKYoJ5clxitIEYtXOsp3pBCO904qog 1zJ94A3gfDP4vuf5TIU4b8Za0ohrlEsOg2muRL8gET60M5ELSYjnpwjzF7QpEaqO 3Wcn+Z6Yk4m5FczgomfDUYjwkB/CI6gR7PW0+n7akBXzoPTXxwKAfDU6IfczsaTQ ZS7hCfoeFyVGiJoeeFcRYXvxwyzOJZujMvcHAP/GjrY+jJeQiPg9Z6k1Uigf1GUq HKBIPYu7ktDJExil3LADu7/uEsR1sE29E6/mZFeUjkMugtV1KRmz+eDXWedVfSrZ E350uZSbk3sMzeqtqrvxuHdXJrqnjcDECasxRDn/0vzujmwy8BJ48Mgf7CEbSlKj w3IKpN42pcGrz69yFXw/REl707DiUEfBie9r2Vt0ZoWptg+vG+elqpv3/jIH7JiE KhViTRAmJt1M7hQN65WPrWs1Fcbb4b2xwfh++bUS8+ZVWbIQjTUu9k1PpXitrVYF ELZP5WIihQR0kZoUPU7s =XOzf -----END PGP SIGNATURE----- --=-=-=--