From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759496AbcGKQAh (ORCPT ); Mon, 11 Jul 2016 12:00:37 -0400 Received: from down.free-electrons.com ([37.187.137.238]:47191 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755085AbcGKQAg (ORCPT ); Mon, 11 Jul 2016 12:00:36 -0400 From: Gregory CLEMENT To: Ben Dooks Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , linux-kernel@lists.codethink.co.uk, Andrew Lunn , Jason Cooper , linux-kernel@vger.kernel.org, Evan Wang Subject: Re: [PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static References: <1466522179-22198-1-git-send-email-ben.dooks@codethink.co.uk> <1466522179-22198-2-git-send-email-ben.dooks@codethink.co.uk> <9446011.bTD6e4eDRY@wuerfel> Date: Mon, 11 Jul 2016 18:00:33 +0200 In-Reply-To: <9446011.bTD6e4eDRY@wuerfel> (Arnd Bergmann's message of "Tue, 21 Jun 2016 17:31:13 +0200") Message-ID: <87inwctba6.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ben, On mar., juin 21 2016, Arnd Bergmann wrote: > On Tuesday, June 21, 2016 4:16:19 PM CEST Ben Dooks wrote: >> >> -struct syscore_ops mvebu_mbus_syscore_ops = { >> +static struct syscore_ops mvebu_mbus_syscore_ops = { >> .suspend = mvebu_mbus_suspend, >> .resume = mvebu_mbus_resume, >> }; >> > > > Looks good, but I immediately thought it should be "const" as well. > Unfortunately there is a list_head in them, so that isn't easy, > but if anyone has an idea for how to make these all const, that > would be nice. > > Anyway, that shouldn't stop your patch from getting merged, so > > Acked-by: Arnd Bergmann > > (also for patch 1/2). So I applied both patch in mvebu/cleanup Thanks, Gregory > > Arnd -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com