From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161523AbcFGPT1 (ORCPT ); Tue, 7 Jun 2016 11:19:27 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:22435 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932609AbcFGPTY convert rfc822-to-8bit (ORCPT ); Tue, 7 Jun 2016 11:19:24 -0400 X-IronPort-AV: E=Sophos;i="5.26,433,1459839600"; d="scan'208";a="293966150" X-IronPort-AV: E=McAfee;i="5700,7163,8189"; a="713066836" From: "Valo, Kalle" To: David Binderman CC: "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dcb314@hotmail.com" , "ath6kl@lists.infradead.org" Subject: Re: linux-4.7-rc2/drivers/net/wireless/ath/ath6kl/wmi.c:2547]: (style) Redundant condition Thread-Topic: linux-4.7-rc2/drivers/net/wireless/ath/ath6kl/wmi.c:2547]: (style) Redundant condition Thread-Index: AQHRwM80CcyWdZhFkEWeH/iFdodckA== Date: Tue, 7 Jun 2016 15:19:16 +0000 Message-ID: <87inxlni19.fsf@kamboji.qca.qualcomm.com> References: In-Reply-To: (David Binderman's message of "Tue, 7 Jun 2016 16:13:48 +0100") Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.251.52.12] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Binderman writes: > Hello there, > > linux-4.7-rc2/drivers/net/wireless/ath/ath6kl/wmi.c:2547]: (style) > Redundant condition: If 'EXPR <= 7', the comparison 'EXPR < 8' is > always true. > > Source code is > > if (!((params->user_pri < 8) && > (params->user_pri <= 0x7) && > > This might be a possible cut'n'paste error. This should be recently fixed: https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next&id=93b4a09f0f3068e3190548393f39262e5295960e > Also in the same file > > [drivers/net/wireless/ath/ath6kl/wmi.c:1220]: (style) Variable 'rate' > is assigned a value that is never used. > [drivers/net/wireless/ath/ath6kl/wmi.c:1484]: (style) Variable > 'new_threshold' is assigned a value that is never used. > [drivers/net/wireless/ath/ath6kl/wmi.c:3521]: (style) Variable 'ret' > is assigned a value that is never used. I guess these are still valid. -- Kalle Valo