From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757455AbcAJU2B (ORCPT ); Sun, 10 Jan 2016 15:28:01 -0500 Received: from smtp04.smtpout.orange.fr ([80.12.242.126]:22557 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757267AbcAJU17 (ORCPT ); Sun, 10 Jan 2016 15:27:59 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sun, 10 Jan 2016 21:27:58 +0100 X-ME-IP: 92.149.187.47 From: Robert Jarzmik To: Tomi Valkeinen , Jean-Christophe Plagniol-Villard Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] video: fbdev: pxafb: fix out of memory error path References: <1450527271-21841-1-git-send-email-robert.jarzmik@free.fr> X-URL: http://belgarath.falguerolles.org/ Date: Sun, 10 Jan 2016 21:27:56 +0100 In-Reply-To: <1450527271-21841-1-git-send-email-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Sat, 19 Dec 2015 13:14:31 +0100") Message-ID: <87io31dvsj.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Robert Jarzmik writes: > As seen by Julia, the initial allocation memory is not checked anymore > after commit "video: fbdev: pxafb: initial devicetree conversion". > Introduce back the removed test. > > Reported-by: Julia Lawall > Signed-off-by: Robert Jarzmik > --- > drivers/video/fbdev/pxafb.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c > index 8588dd683105..54666424a720 100644 > --- a/drivers/video/fbdev/pxafb.c > +++ b/drivers/video/fbdev/pxafb.c > @@ -2252,6 +2252,8 @@ static int pxafb_probe(struct platform_device *dev) > ret = -ENOMEM; > pdata = dev_get_platdata(&dev->dev); > inf = devm_kmalloc(&dev->dev, sizeof(*inf), GFP_KERNEL); > + if (!inf) > + goto failed; > > if (pdata) { > *inf = *pdata; Tomi, Jean-Christophe, Can you carry out this fix please ? Cheers. -- Robert