From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932986AbbKFNTQ (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 Nov 2015 08:19:16 -0500
Received: from mx1.redhat.com ([209.132.183.28]:47111 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932908AbbKFNTP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 Nov 2015 08:19:15 -0500
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@citrix.com>,
        Mark Rutland <mark.rutland@arm.com>, <xen-devel@lists.xensource.com>,
        <linux@arm.linux.org.uk>, Ian Campbell <Ian.Campbell@citrix.com>,
        <arnd@arndb.de>, <marc.zyngier@arm.com>, <catalin.marinas@arm.com>,
        <konrad.wilk@oracle.com>, <will.deacon@arm.com>,
        <linux-kernel@vger.kernel.org>, <olof@lixom.net>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v11 5/5] xen/arm: account for stolen ticks
References: <alpine.DEB.2.02.1511051502270.13541@kaball.uk.xensource.com>
	<1446737696-9749-5-git-send-email-stefano.stabellini@eu.citrix.com>
	<20151105165743.GG32247@leverpostej>
	<alpine.DEB.2.02.1511061126500.13541@kaball.uk.xensource.com>
	<563C91FD.7060703@citrix.com>
Date: Fri, 06 Nov 2015 14:19:08 +0100
In-Reply-To: <563C91FD.7060703@citrix.com> (David Vrabel's message of "Fri, 6
	Nov 2015 11:41:49 +0000")
Message-ID: <87io5fp8oj.fsf@vitty.brq.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

David Vrabel <david.vrabel@citrix.com> writes:

> On 06/11/15 11:39, Stefano Stabellini wrote:
>> On Thu, 5 Nov 2015, Mark Rutland wrote:
>>>>  static void xen_percpu_init(void)
>>>>  {
>>>>  	struct vcpu_register_vcpu_info info;
>>>> @@ -104,6 +120,8 @@ static void xen_percpu_init(void)
>>>>  	BUG_ON(err);
>>>>  	per_cpu(xen_vcpu, cpu) = vcpup;
>>>>  
>>>> +	xen_setup_runstate_info(cpu);
>>>
>>> Does the runstate memory area get unregsitered when a kernel tears
>>> things down, or is kexec somehow inhibited for xen guests?
>>>
>>> i couldn't spot either happening, but I may have missed it.
>> 
>> I don't think that the runstate memory area needs to be unregistered for
>> kexec, but I am not very knowledgeble on kexec and Xen, CC'ing Vitaly
>> and David.
>
> There's a whole pile of other state needing to be reset for kexec (event
> channels and grant tables for example).  The guest needs to soft reset
> itself (available in Xen 4.6) before kexec'ing another kernel.

Unfortunately, it's 4.7. Soft reset patch series was merged after 4.6
freeze so it is only available in current master git branch.

>
> This soft reset would also including cleaning up this shared memory region.
>
> David

-- 
  Vitaly