From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752082AbbJLNCs (ORCPT ); Mon, 12 Oct 2015 09:02:48 -0400 Received: from down.free-electrons.com ([37.187.137.238]:37953 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751426AbbJLNCp (ORCPT ); Mon, 12 Oct 2015 09:02:45 -0400 From: Gregory CLEMENT To: Mans Rullgard Cc: Sekhar Nori , Kevin Hilman , Russell King , Hartley Sweeten , Ryan Mallon , Hans Ulli Kroll , Imre Kaloz , Krzysztof Halasa , Eric Miao , Haojian Zhuang , Tony Lindgren , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Mikael Starvik , Jesper Nilsson , Michal Simek , Ralf Baechle , Chris Zankel , Max Filippov , Daniel Lezcano , Thomas Gleixner , Srinivas Kandagatla , Maxime Coquelin , Patrice Chotard , Stephen Warren , Lee Jones , Eric Anholt , =?utf-8?Q?S=C3=B6ren?= Brinkmann , Linus Walleij , Alexander Shiyan , Kukjin Kim , Krzysztof Kozlowski , Carlo Caione , Maxime Ripard , Thierry Reding , Alexandre Courbot , Baruch Siach , Barry Song , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-cris-kernel@axis.com, linux-mips@linux-mips.org, linux-xtensa@linux-xtensa.org, kernel@stlinux.com, linux-rpi-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH] sched_clock: add data pointer argument to read callback References: <1444427858-576-1-git-send-email-mans@mansr.com> Date: Mon, 12 Oct 2015 15:02:42 +0200 In-Reply-To: <1444427858-576-1-git-send-email-mans@mansr.com> (Mans Rullgard's message of "Fri, 9 Oct 2015 22:57:35 +0100") Message-ID: <87io6c6xzh.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mans, On ven., oct. 09 2015, Mans Rullgard wrote: > This passes a data pointer specified in the sched_clock_register() > call to the read callback allowing simpler implementations thereof. > > In this patch, existing uses of this interface are simply updated > with a null pointer. > > Signed-off-by: Mans Rullgard > --- [...] > diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c > index 2162796..a13b73b 100644 > --- a/drivers/clocksource/time-armada-370-xp.c > +++ b/drivers/clocksource/time-armada-370-xp.c > @@ -92,7 +92,7 @@ static void local_timer_ctrl_clrset(u32 clr, u32 set) > local_base + TIMER_CTRL_OFF); > } > > -static u64 notrace armada_370_xp_read_sched_clock(void) > +static u64 notrace armada_370_xp_read_sched_clock(void *data) > { > return ~readl(timer_base + TIMER0_VAL_OFF); > } > @@ -290,7 +290,8 @@ static void __init armada_370_xp_timer_common_init(struct device_node *np) > /* > * Set scale and timer for sched_clock. > */ > - sched_clock_register(armada_370_xp_read_sched_clock, 32, timer_clk); > + sched_clock_register(armada_370_xp_read_sched_clock, 32, timer_clk, > + NULL); > > clocksource_mmio_init(timer_base + TIMER0_VAL_OFF, > "armada_370_xp_clocksource", For the time-armada-370-xp.c file: Acked-by: Gregory CLEMENT Thanks, Gregory -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com