From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Watts <rrw@kynesim.co.uk>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH 001/003] Attempt to cope with device changes and delayed kobject deallocation
Date: Wed, 10 Jun 2015 07:46:16 +0100 [thread overview]
Message-ID: <87ioaw6oxz.fsf@linaro.org> (raw)
In-Reply-To: <555B5353.2000204@kynesim.co.uk>
Richard Watts <rrw@kynesim.co.uk> writes:
> Expose kobject_get_unless_zero() which will shortly be
> needed by get_device_parent().
>
> Signed-off-by: Richard Watts <rrw@kynesim.co.uk>
> ---
> include/linux/kobject.h | 1 +
> lib/kobject.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/kobject.h b/include/linux/kobject.h
> index 2d61b90..662b136 100644
> --- a/include/linux/kobject.h
> +++ b/include/linux/kobject.h
> @@ -107,6 +107,7 @@ extern int __must_check kobject_rename(struct
> kobject *, const char *new_name);
> extern int __must_check kobject_move(struct kobject *, struct kobject *);
>
> extern struct kobject *kobject_get(struct kobject *kobj);
> +extern struct kobject * __must_check kobject_get_unless_zero(struct
> kobject *kobj);
> extern void kobject_put(struct kobject *kobj);
>
> extern const void *kobject_namespace(struct kobject *kobj);
> diff --git a/lib/kobject.c b/lib/kobject.c
> index 3b841b9..3ba1db4 100644
> --- a/lib/kobject.c
> +++ b/lib/kobject.c
> @@ -586,7 +586,7 @@ struct kobject *kobject_get(struct kobject *kobj)
> return kobj;
> }
>
> -static struct kobject * __must_check kobject_get_unless_zero(struct
> kobject *kobj)
> +struct kobject * __must_check kobject_get_unless_zero(struct kobject *kobj)
> {
> if (!kref_get_unless_zero(&kobj->kref))
> kobj = NULL;
Hi Richard,
checkpatch is complaining about some trailing whitespace in this patch.
> --
> 1.9.1
--
Alex Bennée
next prev parent reply other threads:[~2015-06-10 6:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 15:13 [PATCH 000/003] Attempt to cope with device changes and delayed kobject deallocation Richard Watts
2015-05-19 15:14 ` [PATCH 001/003] " Richard Watts
2015-06-10 6:46 ` Alex Bennée [this message]
2015-05-19 15:15 ` [PATCH 002/003] " Richard Watts
2015-05-19 15:15 ` [PATCH 003/003] " Richard Watts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ioaw6oxz.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rrw@kynesim.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox