From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753982AbbCFHxH (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 Mar 2015 02:53:07 -0500
Received: from mga02.intel.com ([134.134.136.20]:47128 "EHLO mga02.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753263AbbCFHxE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 Mar 2015 02:53:04 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,351,1422950400"; 
   d="scan'208";a="687821841"
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Joe Perches <joe@perches.com>, Andrew Morton <akpm@linux-foundation.org>
Cc: Ville =?utf-8?B?U3lyasOkbMOk?= <ville.syrjala@linux.intel.com>,
        "Purushothaman\, Vijay A" <vijay.a.purushothaman@linux.intel.com>,
        Andy Whitcroft <apw@canonical.com>,
        LKML <linux-kernel@vger.kernel.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] checkpatch: Add spell checking of email subject line
In-Reply-To: <1425574649.31859.14.camel@perches.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <1424977312-24902-1-git-send-email-ville.syrjala@linux.intel.com> <54F719A2.50405@linux.intel.com> <20150304151002.GS11371@intel.com> <87twxz3n4p.fsf@intel.com> <1425574649.31859.14.camel@perches.com>
User-Agent: Notmuch/0.19+67~g70b5ead (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu)
Date: Fri, 06 Mar 2015 09:54:25 +0200
Message-ID: <87ioeetvbi.fsf@intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 05 Mar 2015, Joe Perches <joe@perches.com> wrote:
> Only commit log and patch additions are checked for
> typos and spelling errors currently.  Add a check
> of the email subject line too.
>
> Suggested-by: Jani Nikula <jani.nikula@linux.intel.com>
> Signed-off-by: Joe Perches <joe@perches.com>

Thanks Joe.

FWIW,

Tested-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  scripts/checkpatch.pl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 421bbb4..c061a63 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2303,7 +2303,8 @@ sub process {
>  		}
>  
>  # Check for various typo / spelling mistakes
> -		if (defined($misspellings) && ($in_commit_log || $line =~ /^\+/)) {
> +		if (defined($misspellings) &&
> +		    ($in_commit_log || $line =~ /^(?:\+|Subject:)/i)) {
>  			while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:$|[^a-z@])/gi) {
>  				my $typo = $1;
>  				my $typo_fix = $spelling_fix{lc($typo)};
>
>

-- 
Jani Nikula, Intel Open Source Technology Center