From: Namhyung Kim <namhyung@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>, Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 2/4] perf tools: Fix one of the probe events to exclude kernel
Date: Wed, 13 Aug 2014 14:34:33 +0900 [thread overview]
Message-ID: <87iolxdkba.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1407855871-15024-3-git-send-email-adrian.hunter@intel.com> (Adrian Hunter's message of "Tue, 12 Aug 2014 18:04:29 +0300")
On Tue, 12 Aug 2014 18:04:29 +0300, Adrian Hunter wrote:
> When probing the kernel API the kernel should be excluded
> otherwise the probe will fail for users with insufficient
> privilege to profile the kernel.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> ---
> tools/perf/util/record.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/record.c b/tools/perf/util/record.c
> index 787b882..68ad2d0 100644
> --- a/tools/perf/util/record.c
> +++ b/tools/perf/util/record.c
> @@ -47,7 +47,7 @@ out_delete:
>
> static bool perf_probe_api(setup_probe_fn_t fn)
> {
> - const char *try[] = {"cycles:u", "instructions:u", "cpu-clock", NULL};
> + const char *try[] = {"cycles:u", "instructions:u", "cpu-clock:u", NULL};
> struct cpu_map *cpus;
> int cpu, ret, i = 0;
next prev parent reply other threads:[~2014-08-13 5:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 15:04 [PATCH 0/4] perf tools: API probing fixes Adrian Hunter
2014-08-12 15:04 ` [PATCH 1/4] perf tools: Fix CLOEXEC probe for perf_event_paranoid == 2 Adrian Hunter
2014-08-13 5:33 ` Namhyung Kim
2014-08-14 8:44 ` [tip:perf/core] " tip-bot for Adrian Hunter
2014-08-12 15:04 ` [PATCH 2/4] perf tools: Fix one of the probe events to exclude kernel Adrian Hunter
2014-08-13 5:34 ` Namhyung Kim [this message]
2014-08-14 8:44 ` [tip:perf/core] " tip-bot for Adrian Hunter
2014-08-12 15:04 ` [PATCH 3/4] perf tools: Fix probing the kernel API with cpu-wide events Adrian Hunter
2014-08-13 5:37 ` Namhyung Kim
2014-08-13 5:51 ` Adrian Hunter
2014-08-14 8:45 ` [tip:perf/core] " tip-bot for Adrian Hunter
2014-08-12 15:04 ` [PATCH 4/4] perf tools: Prefer to use a cpu-wide event for probing CLOEXEC Adrian Hunter
2014-08-14 8:45 ` [tip:perf/core] " tip-bot for Adrian Hunter
2014-08-13 11:28 ` [PATCH 0/4] perf tools: API probing fixes Jiri Olsa
2014-08-13 19:22 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iolxdkba.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox