From: Namhyung Kim <namhyung@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Javi Merino <javi.merino@arm.com>
Subject: Re: [PATCH 4/4] tools lib traceevent: Added support for __get_bitmask() macro
Date: Tue, 03 Jun 2014 11:43:26 +0900 [thread overview]
Message-ID: <87iooiemr5.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20140516140502.628373326@goodmis.org> (Steven Rostedt's message of "Fri, 16 May 2014 10:02:19 -0400")
Hi Steve,
On Fri, 16 May 2014 10:02:19 -0400, Steven Rostedt wrote:
> @@ -3691,6 +3784,23 @@ static void print_str_arg(struct trace_seq *s, void *data, int size,
> case PRINT_BSTRING:
> print_str_to_seq(s, format, len_arg, arg->string.string);
> break;
> + case PRINT_BITMASK: {
> + int bitmask_offset;
> + int bitmask_size;
> +
> + if (arg->bitmask.offset == -1) {
> + struct format_field *f;
> +
> + f = pevent_find_any_field(event, arg->bitmask.bitmask);
> + arg->bitmask.offset = f->offset;
> + }
> + bitmask_offset = data2host4(pevent, data + arg->string.offset);
s/string.offset/bitmask.offset/
Thanks,
Namhyung
> + bitmask_size = bitmask_offset >> 16;
> + bitmask_offset &= 0xffff;
> + print_bitmask_to_seq(pevent, s, format, len_arg,
> + data + bitmask_offset, bitmask_size);
> + break;
> + }
next prev parent reply other threads:[~2014-06-03 2:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 14:02 [PATCH 0/4] tools lib traceevent: bitmask handling and plugin updates Steven Rostedt
2014-05-16 14:02 ` [PATCH 1/4] tools lib traceevent: Add flag to not load event plugins Steven Rostedt
2014-05-16 14:02 ` [PATCH 2/4] tools lib traceevent: Add options to plugins Steven Rostedt
2014-05-19 14:29 ` Namhyung Kim
2014-05-20 2:06 ` Steven Rostedt
2014-05-20 2:15 ` Namhyung Kim
2014-06-03 3:12 ` Steven Rostedt
2014-05-16 14:02 ` [PATCH 3/4] tools lib traceevent: Add options to function plugin Steven Rostedt
2014-05-16 14:02 ` [PATCH 4/4] tools lib traceevent: Added support for __get_bitmask() macro Steven Rostedt
2014-06-03 2:43 ` Namhyung Kim [this message]
2014-06-03 2:47 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iooiemr5.fsf@sejong.aot.lge.com \
--to=namhyung@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=javi.merino@arm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox