Re: [PATCH v1 03/11] perf: Allow for multiple ring buffers per event

Andi Kleen
2014-03-10T17:24:44Z

> > Wouldn't we have to teach a ton of code how to be IRQ safe for this to
> > work? Just step one: how do we go modifying page tables safely from an
> > interrupt? mm->page_table_lock is a plain non-irq spinlock.
>
> Yes, this does look more than just tricky even if we move the bulk of
> interrupt code to an irq_work. Peter, are you quite sure this is what we
> want to do just for exporting trace buffers to userspace?

The other big problem is scalability. Even if it was somehow possible
to make this scheme work the IPIs for flushing would kill performance
on any multi threaded client. Given perf is not multi-threaded today, but
it doesn't seem a good idea to design the interface assuming no client ever
will be.

-Andi