Re: [PATCH v1 09/11] x86: perf: intel_pt: Add core dump functionality

Andi Kleen
2014-02-07T00:00:16Z

Alexander Shishkin <alexander.shishkin@linux.intel.com> writes:
> +
> +static void pt_trace_core_output(struct coredump_params *cprm,
> + struct perf_event *event,
> + unsigned long len)
> +{
> + struct pt_buffer *buf;
> + u64 from, to;
> + int ret;
> +
> + buf = itrace_priv(event);
> +
> + if (!dump_emit(cprm, pt_pmu.capstr, pt_pmu.caplen))
> + return;

It would be nicer if this was a separate note, instead of just being
concatenated with the rest of the data.

Would make simpler parsing and be cleaner.

-Andi

--
ak@linux.intel.com -- Speaking for myself only