Re: [PATCH v1 09/11] x86: perf: intel_pt: Add core dump functionality

Alexander Shishkin
2014-02-07T09:09:35Z

Andi Kleen <andi@firstfloor.org> writes:

> Alexander Shishkin <alexander.shishkin@linux.intel.com> writes:
>> +
>> +static void pt_trace_core_output(struct coredump_params *cprm,
>> + struct perf_event *event,
>> + unsigned long len)
>> +{
>> + struct pt_buffer *buf;
>> + u64 from, to;
>> + int ret;
>> +
>> + buf = itrace_priv(event);
>> +
>> + if (!dump_emit(cprm, pt_pmu.capstr, pt_pmu.caplen))
>> + return;
>
> It would be nicer if this was a separate note, instead of just being
> concatenated with the rest of the data.
>
> Would make simpler parsing and be cleaner.

So long as we won't have to include traces from two different pmus in
the same core file, then matching these sections may provide another
challenge. Doesn't seem like a sensible scenario, though.

Regards,
--
Alex