Re: [PATCH v1 09/11] x86: perf: intel_pt: Add core dump functionality

Alexander Shishkin
2014-02-07T09:04:27Z

Andi Kleen <ak@linux.intel.com> writes:

>> char *buf)
>> @@ -114,6 +143,7 @@ static ssize_t pt_cap_store(struct device *cdev,
>> return -EINVAL;
>>
>> pt_cap_set(cap, new);
>> + pt_cap_string();
>
> Don't we need some lock here? Otherwise it may leak memory with racing writes
> and become inconsistent.

Good point.

Regards,
--
Alex