Re: [PATCH 1/6] perf report: Use pr_*() functions if possible

Namhyung Kim
2013-12-20T01:32:42Z

On Thu, 19 Dec 2013 10:30:47 -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Dec 19, 2013 at 04:00:06PM +0900, Namhyung Kim escreveu:
>> - if (verbose > 3)
>> - perf_session__fprintf(session, stdout);
>> + if (use_browser == 0) {
>> + if (verbose > 3)
>> + perf_session__fprintf(session, stdout);
>>
>> - if (verbose > 2)
>> - perf_session__fprintf_dsos(session, stdout);
>> + if (verbose > 2)
>> + perf_session__fprintf_dsos(session, stdout);
>>
>> - if (dump_trace) {
>> - perf_session__fprintf_nr_events(session, stdout);
>> - return 0;
>> + if (dump_trace) {
>> + perf_session__fprintf_nr_events(session, stdout);
>> + return 0;
>> + }
>> }
>
> This should be in a different patch, one that is related just to
> dump_trace, i.e. if -D, aka dump_trace (right?) is enabled, then
> probably we won't be initializing the TUI/GUI, no?

Yes, the dump_trace will make use_browser = 0. So I just moved it under
the if (use_browser == 0).

>
> So having a patch that deals just with conversions of fprintf ->
> pr_{err,etc} and another that deals with dump_trace related seems to be
> the best course of action.

Okay, I'll split this into two.

Thanks,
Namhyung