Re: [PATCH 1/6] perf report: Use pr_*() functions if possible

Arnaldo Carvalho de Melo
2013-12-19T13:30:57Z

Em Thu, Dec 19, 2013 at 04:00:06PM +0900, Namhyung Kim escreveu:
> From: Namhyung Kim <namhyung.kim@lge.com>
>
> There're some places printing a message to stdout/err directly. It
> should be converted to use proper error printing functions instead.
>
> If it's not possible, just do it when --stdio was enabled only.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/builtin-report.c | 24 +++++++++++++-----------
> 1 file changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 3a14dbed387c..a1f72b471a96 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -321,8 +321,8 @@ static int process_sample_event(struct perf_tool *tool,
> int ret;
>
> if (perf_event__preprocess_sample(event, machine, &al, sample) < 0) {
> - fprintf(stderr, "problem processing %d event, skipping it.\n",
> - event->header.type);
> + pr_debug("problem processing %d event, skipping it.\n",
> + event->header.type);
> return -1;
> }
>
> @@ -552,15 +552,17 @@ static int __cmd_report(struct perf_report *rep)
> desc);
> }
>
> - if (verbose > 3)
> - perf_session__fprintf(session, stdout);
> + if (use_browser == 0) {
> + if (verbose > 3)
> + perf_session__fprintf(session, stdout);
>
> - if (verbose > 2)
> - perf_session__fprintf_dsos(session, stdout);
> + if (verbose > 2)
> + perf_session__fprintf_dsos(session, stdout);
>
> - if (dump_trace) {
> - perf_session__fprintf_nr_events(session, stdout);
> - return 0;
> + if (dump_trace) {
> + perf_session__fprintf_nr_events(session, stdout);
> + return 0;
> + }
> }

This should be in a different patch, one that is related just to
dump_trace, i.e. if -D, aka dump_trace (right?) is enabled, then
probably we won't be initializing the TUI/GUI, no?

So having a patch that deals just with conversions of fprintf ->
pr_{err,etc} and another that deals with dump_trace related seems to be
the best course of action.

- Arnaldo

> nr_samples = 0;
> @@ -720,7 +722,7 @@ parse_callchain_opt(const struct option *opt, const char *arg, int unset)
> return -1;
> setup:
> if (callchain_register_param(&callchain_param) < 0) {
> - fprintf(stderr, "Can't register callchain params\n");
> + pr_err("Can't register callchain params\n");
> return -1;
> }
> return 0;
> @@ -942,7 +944,7 @@ repeat:
> }
> if (report.mem_mode) {
> if (sort__mode == SORT_MODE__BRANCH) {
> - fprintf(stderr, "branch and mem mode incompatible\n");
> + pr_err("branch and mem mode incompatible\n");
> goto error;
> }
> sort__mode = SORT_MODE__MEMORY;
> --
> 1.7.11.7