public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@linaro.org>
To: Tejun Heo <tj@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
	Linaro Networking <linaro-networking@linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	bsd@redhat.com, laijs@cn.fujitsu.com
Subject: Re: [Query] Ticks happen in pair for NO_HZ_FULL cores ?
Date: Thu, 12 Dec 2013 16:32:25 -0800	[thread overview]
Message-ID: <87iout615y.fsf@linaro.org> (raw)
In-Reply-To: <20131211211400.GB7683@mtj.dyndns.org> (Tejun Heo's message of "Wed, 11 Dec 2013 16:14:00 -0500")

Tejun Heo <tj@kernel.org> writes:

> Hey, guys.
>
> On Wed, Dec 11, 2013 at 02:22:14PM +0100, Frederic Weisbecker wrote:
>> I fear I don't understand your question. Do you mean why don't we prevent from
>> that bdi writeback work to run when we are in full dynticks mode?
>> 
>> We can't just ignore workqueues and timers callback when they are scheduled
>> otherwise the kernel is going to behave randomly.
>> 
>> OTOH what we can do is to work on these per cpu workqueues and timers and do
>> what's necessary to avoid them to fire, as explained in detail there Documentation/kernel-per-CPU-kthreads.txt
>
> Hmmm... some per-cpu workqueues can be turned into unbound ones and
> the writeback is one of those.  

Ah, looks like the writeback one is already unbound, and configurable
from sysfs.

Viresh, add this to your test script, and it should get this workqueue
out of the way:

   # pin the writeback workqueue to CPU0
   echo 1 > /sys/bus/workqueue/devices/writeback/cpumask

Kevin

> Currently, this is used for
> powersaving on mobile but could also be useful for jitter control.  In
> the long term, it could be beneficial to strictly distinguish the
> workqueues which really need per-cpu behavior and the ones which are
> per-cpu just for optimization.
>
>> There is also the problem of unbound workqueues for which we don't
>> have a solution yet. But the idea is that we could tweak their
>> affinity from sysfs.
>
> Yes, this is a long term todo item but I'm currently a bit too swamped
> to tackle it myself.  cc'ing Lai, who has pretty good knowledge of
> workqueue internals, and Bandan, who seemed interested in working on
> implementing default attrs.
>
> Thanks.

  reply	other threads:[~2013-12-13  0:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAKohponch=o3nBKTmakA87OiN=HbgnEwJUL23mGkjQiNoJWjWw@mail.gmail.com>
2013-12-11 13:22 ` [Query] Ticks happen in pair for NO_HZ_FULL cores ? Frederic Weisbecker
2013-12-11 21:14   ` Tejun Heo
2013-12-13  0:32     ` Kevin Hilman [this message]
2013-12-17 10:35   ` Viresh Kumar
2013-12-17 16:35     ` Kevin Hilman
2013-12-17 16:57       ` Frederic Weisbecker
2013-12-18  4:38       ` Viresh Kumar
2013-12-18 13:51         ` Kevin Hilman
2013-12-18 14:33           ` [LNG] " Viresh Kumar
2013-12-23  8:18             ` Viresh Kumar
2014-01-07  7:49               ` Viresh Kumar
2014-01-07  8:47               ` Peter Zijlstra
2014-01-07  8:55                 ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iout615y.fsf@linaro.org \
    --to=khilman@linaro.org \
    --cc=bsd@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linaro-networking@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox