From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755841Ab3KEXPB (ORCPT ); Tue, 5 Nov 2013 18:15:01 -0500 Received: from mic92-1-81-57-185-249.fbx.proxad.net ([81.57.185.249]:52865 "EHLO smtp.natisbad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755462Ab3KEXO7 (ORCPT ); Tue, 5 Nov 2013 18:14:59 -0500 X-Hashcash: 1:20:131105:thomas.petazzoni@free-electrons.com::B+beKnHvDd9mFzZR:000000000000000000000000001RHC From: arno@natisbad.org (Arnaud Ebalard) To: Sebastian Hesselbarth Cc: Jason Gunthorpe , Andrew Lunn , Jason Cooper , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, David Miller , Lennert Buytenhek , Thomas Petazzoni Subject: Re: [PATCH] net: mv643xx_eth: Add missing phy_addr_set in DT mode References: <1383611239-14556-1-git-send-email-jgunthorpe@obsidianresearch.com> <87sivacxcf.fsf@natisbad.org> <52796E82.5010800@gmail.com> X-PGP-Key-URL: http://natisbad.org/arno@natisbad.org.asc X-Fingerprint: D3A5 B68A 839B 38A5 815A 781B B77C 0748 A7AE 341B X-Hashcash: 1:20:131105:davem@davemloft.net::a6YQVclk//bvC5iM:0000000000000000000000000000000000000000000IBt X-Hashcash: 1:20:131105:sebastian.hesselbarth@gmail.com::X2SCVt7paBhSpedj:0000000000000000000000000000000fdV X-Hashcash: 1:20:131105:andrew@lunn.ch::VPA2GMjCM6T+H6jQ:0000utx X-Hashcash: 1:20:131105:linux-kernel@vger.kernel.org::EYct8vbbDimDuVZA:00000000000000000000000000000000014BF X-Hashcash: 1:20:131105:linux-arm-kernel@lists.infradead.org::ZFK+4z5tSRVUhU9B:00000000000000000000000001x0h X-Hashcash: 1:20:131105:jason@lakedaemon.net::x/9Pp6c+dyZQhBso:000000000000000000000000000000000000000002Dbg X-Hashcash: 1:20:131105:netdev@vger.kernel.org::sxqBsC/cwIK/cKvi:0000000000000000000000000000000000000002/TA X-Hashcash: 1:20:131105:jgunthorpe@obsidianresearch.com::bAIJjKHKzQGEStGF:00000000000000000000000000000041H8 X-Hashcash: 1:20:131105:buytenh@wantstofly.org::nxSYO+fiigEsPyrH:00000000000000000000000000000000000000062M7 X-Hashcash: 1:20:131105:linuxppc-dev@lists.ozlabs.org::jY5YV1gO1HEjeG+0:00000000000000000000000000000000CrzD X-Hashcash: 1:20:131105:benh@kernel.crashing.org::hyEBGjyjfmCBFP8i:0000000000000000000000000000000000000Cqil Date: Wed, 06 Nov 2013 00:14:34 +0100 In-Reply-To: <52796E82.5010800@gmail.com> (Sebastian Hesselbarth's message of "Tue, 05 Nov 2013 23:17:38 +0100") Message-ID: <87iow6cug5.fsf@natisbad.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Sebastian Hesselbarth writes: > On 11/05/2013 11:12 PM, Arnaud Ebalard wrote: >> Hi Jason, >> >> Jason Gunthorpe writes: >> >>> Commit cc9d4598 'net: mv643xx_eth: use of_phy_connect if phy_node >>> present' made the call to phy_scan optional, if the DT has a link to >>> the phy node. >>> >>> However phy_scan has the side effect of calling phy_addr_set, which >>> writes the phy MDIO address to the ethernet controller. If phy_addr_set >>> is not called, and the bootloader has not set the correct address then >>> the driver will fail to function. >> >> Thanks *a lot* for fixing this one! I had the issue on my ReadyNAS 102 >> (Armada 370 based) which I had put on a todo list and temporarily > > Erm, just to make sure: Armada 370 isn't using mv643xx_eth but mvneta, > are you sure it is (was) related to Jason's fix? Thanks for pointing this, Sebastian and my apologies for the noise. Jason's fix is indeed for a file which is not compiled for my RN102. As the problem perfectly matched the issue I had and current kernel w/ the patch applied does indeed fix it, I did not try and do the test w/o the patch applied. It would have showed the problem was fixed by something else in 3.12. Well, I spent some time digging the changes on mvneta.c and: commit 714086029116b6b0a34e67ba1dd2f0d1cf26770c Author: Thomas Petazzoni Date: Wed Sep 4 16:21:18 2013 +0200 net: mvneta: properly disable HW PHY polling and ensure adjust_link() works This commit fixes a long-standing bug that has been reported by many users: on some Armada 370 platforms, only the network interface that has been used in U-Boot to tftp the kernel works properly in Linux. The other network interfaces can see a 'link up', but are unable to transmit data. The reports were generally made on the Armada 370-based Mirabox, but have also been given on the Armada 370-RD board. [SNIP] $ git tag --contains 714086029116 v3.12 v3.12-rc1 v3.12-rc2 v3.12-rc3 v3.12-rc4 v3.12-rc5 v3.12-rc6 v3.12-rc7 So the problem was indeed fixed at the beginning of 3.12 series by Thomas. Anyway, my bad and thanks again for pointing it out. Cheers, a+