From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752760Ab3AUFlQ (ORCPT ); Mon, 21 Jan 2013 00:41:16 -0500 Received: from mail.parknet.co.jp ([210.171.160.6]:55201 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803Ab3AUFlO (ORCPT ); Mon, 21 Jan 2013 00:41:14 -0500 From: OGAWA Hirofumi To: Namjae Jeon Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Ravishankar N Subject: Re: [PATCH] fat: eliminate iterations in fat_search_long in case of EOD References: <1358561990-8216-1-git-send-email-linkinjeon@gmail.com> <87vcasxgre.fsf@devron.myhome.or.jp> Date: Mon, 21 Jan 2013 14:41:09 +0900 In-Reply-To: (Namjae Jeon's message of "Mon, 21 Jan 2013 13:15:17 +0900") Message-ID: <87ip6rxfd6.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Namjae Jeon writes: > 2013/1/20, OGAWA Hirofumi : >> Namjae Jeon writes: >> >>> From: Namjae Jeon >>> >>> When searching a directory for names, we can stop checking for further >>> entries if we detect End of Directory, i.e. if (de->name[0] == 0x00).The >>> current code traverses the cluster chain of a directory until a hit is >>> found or till the last cluster for that directory, ignoring the EOD mark. >>> Fix this. >> >> f_pos still works fine after this change? > Hi OGAWA. > I can not find f_pos usage in fat_search_long function. > Maybe, Have you seen other function such as __fat_readdir ? > Let me know your opinion. Ah, I see. Only ->lookup. So, this makes behavior more strange. I.e. readdir() returns beyond 0, but lookup() can't find it? Thanks. -- OGAWA Hirofumi