Re: [PATCH 10/14] perf tool: Centralize default columns init in perf_hpp__init

Namhyung Kim
2012-11-30T05:06:54Z

Hi Jiri,

On Thu, 29 Nov 2012 13:13:19 +0100, Jiri Olsa wrote:
> On Thu, Nov 29, 2012 at 08:55:47PM +0900, Namhyung Kim wrote:
>> On Wed, 28 Nov 2012 14:52:45 +0100, Jiri Olsa wrote:
>> > Now when diff command is separated from other standard outputs,
>> > we can use perf_hpp__init to initialize all standard columns.
>> >
>> > Moving PERF_HPP__OVERHEAD column init back to perf_hpp__init,
>> > and removing extra enable calls.
>>
>> Why was this needed in the first place? AFAIK it's already there and
>> didn't used only for perf diff.
>
> hm, I think PERF_HPP__OVERHEAD wasn't part of perf_hpp__init and every
> report except for diff command is using it.. so I think it makes sense
> to move it to perf_hpp__init.. maybe I'm missing something.

You're right. The _OVERHEAD column was enabled by default but wasn't
part of the _init function - sorry for the confusion. But what I try to
say was that it can be folded into the patch 1.

Thanks,
Namhyung