Re: [PATCH 10/14] perf tool: Centralize default columns init in perf_hpp__init

Jiri Olsa
2012-11-29T12:14:04Z

On Thu, Nov 29, 2012 at 08:55:47PM +0900, Namhyung Kim wrote:
> On Wed, 28 Nov 2012 14:52:45 +0100, Jiri Olsa wrote:
> > Now when diff command is separated from other standard outputs,
> > we can use perf_hpp__init to initialize all standard columns.
> >
> > Moving PERF_HPP__OVERHEAD column init back to perf_hpp__init,
> > and removing extra enable calls.
>
> Why was this needed in the first place? AFAIK it's already there and
> didn't used only for perf diff.

hm, I think PERF_HPP__OVERHEAD wasn't part of perf_hpp__init and every
report except for diff command is using it.. so I think it makes sense
to move it to perf_hpp__init.. maybe I'm missing something.

The diff command is not using perf_hpp__init, it's building its own
PERF_HPP columns

jirka