From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753667Ab2EGFZj (ORCPT ); Mon, 7 May 2012 01:25:39 -0400 Received: from ozlabs.org ([203.10.76.45]:51304 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751923Ab2EGFYQ (ORCPT ); Mon, 7 May 2012 01:24:16 -0400 From: Rusty Russell To: Jesper Juhl , linux-kernel@vger.kernel.org Cc: Alessio Igor Bogani , Tony Lindgren , Ben Hutchings , Russell King Subject: Re: [PATCH] modpost: Stop grab_file() from leaking filedescriptors if fstat() fails In-Reply-To: References: User-Agent: Notmuch/0.12 (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) Date: Mon, 07 May 2012 13:20:35 +0930 Message-ID: <87ipg8fy44.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 22 Apr 2012 20:40:49 +0200 (CEST), Jesper Juhl wrote: > In case the open() call succeeds but the subsequent fstat() call > fails, then we'll return without close()'ing the filedescriptor. > > Signed-off-by: Jesper Juhl Applied. Thanks, Rusty.