From: Namhyung Kim <namhyung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Jiri Olsa <jolsa@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 9/9] perf tools: Remove auto-generated bison/flex files
Date: Sat, 31 Mar 2012 01:43:13 +0900 [thread overview]
Message-ID: <87iphmm44e.fsf@gmail.com> (raw)
In-Reply-To: <1333123764-15662-10-git-send-email-acme@infradead.org> (Arnaldo Carvalho de Melo's message of "Fri, 30 Mar 2012 13:09:24 -0300")
Hi,
Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> From: Ingo Molnar <mingo@kernel.org>
>
> These should not be in the Git history - they are auto-generated.
>
> Extend the Makefile rules of the parser files to include the generation
> run.
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Link: http://lkml.kernel.org/r/20120327183335.GA27621@gmail.com
> [ committer note: Fixed up O= handling ]
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> tools/perf/Makefile | 47 +-
> tools/perf/util/parse-events-bison.c | 1917 ----------------------------
> tools/perf/util/parse-events-bison.h | 81 --
> tools/perf/util/parse-events-flex.c | 2272 ----------------------------------
> tools/perf/util/parse-events-flex.h | 316 -----
> tools/perf/util/pmu-bison.c | 1663 -------------------------
> tools/perf/util/pmu-bison.h | 73 --
> tools/perf/util/pmu-flex.c | 1821 ---------------------------
> tools/perf/util/pmu-flex.h | 316 -----
> 9 files changed, 30 insertions(+), 8476 deletions(-)
> delete mode 100644 tools/perf/util/parse-events-bison.c
> delete mode 100644 tools/perf/util/parse-events-bison.h
> delete mode 100644 tools/perf/util/parse-events-flex.c
> delete mode 100644 tools/perf/util/parse-events-flex.h
> delete mode 100644 tools/perf/util/pmu-bison.c
> delete mode 100644 tools/perf/util/pmu-bison.h
> delete mode 100644 tools/perf/util/pmu-flex.c
> delete mode 100644 tools/perf/util/pmu-flex.h
>
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index b492e3a..3e61c6f 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -61,8 +61,6 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/ -e s/sun4u/sparc64/ \
>
> CC = $(CROSS_COMPILE)gcc
> AR = $(CROSS_COMPILE)ar
> -FLEX = $(CROSS_COMPILE)flex
> -BISON= $(CROSS_COMPILE)bison
>
> # Additional ARCH settings for x86
> ifeq ($(ARCH),i386)
> @@ -184,7 +182,7 @@ endif
>
> ### --- END CONFIGURATION SECTION ---
>
> -BASIC_CFLAGS = -Iutil/include -Iarch/$(ARCH)/include -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE
> +BASIC_CFLAGS = -Iutil/include -Iarch/$(ARCH)/include -I$(OUTPUT)/util -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE
> BASIC_LDFLAGS =
>
> # Guard against environment variables
> @@ -236,6 +234,25 @@ endif
>
> export PERL_PATH
>
> +FLEX = $(CROSS_COMPILE)flex
> +BISON= $(CROSS_COMPILE)bison
Just out of curiousity, is this $(CROSS_COMPILE) prefix really needed
for flex/bison?
Thanks,
Namhyung
next prev parent reply other threads:[~2012-03-30 16:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 16:09 [GIT PULL 0/9] perf/urgent fixes Arnaldo Carvalho de Melo
2012-03-30 16:09 ` [PATCH 1/9] perf tools: Fix display of first level of callchains Arnaldo Carvalho de Melo
2012-03-30 16:09 ` [PATCH 2/9] perf tools: Fix bug in raw sample parsing Arnaldo Carvalho de Melo
2012-03-30 16:09 ` [PATCH 3/9] perf symbols: Do not include libgen.h Arnaldo Carvalho de Melo
2012-03-30 16:09 ` [PATCH 4/9] perf symbols: Handle NULL dso in dso__name_len Arnaldo Carvalho de Melo
2012-03-30 16:09 ` [PATCH 5/9] perf probe: Finder fails to resolve function name to address Arnaldo Carvalho de Melo
2012-03-30 16:09 ` [PATCH 6/9] perf annotate: addr2line wants addresses in same format as objdump Arnaldo Carvalho de Melo
2012-03-30 16:09 ` [PATCH 7/9] perf tools: Add missing ref-cycles event back to event parser Arnaldo Carvalho de Melo
2012-03-30 16:09 ` [PATCH 8/9] perf annotate: Fix off by one symbol hist size allocation and hit accounting Arnaldo Carvalho de Melo
2012-03-30 16:09 ` [PATCH 9/9] perf tools: Remove auto-generated bison/flex files Arnaldo Carvalho de Melo
2012-03-30 16:43 ` Namhyung Kim [this message]
2012-03-30 17:09 ` David Daney
2012-03-30 22:01 ` Arnaldo Carvalho de Melo
2012-03-31 7:31 ` [GIT PULL 0/9] perf/urgent fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iphmm44e.fsf@gmail.com \
--to=namhyung@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=acme@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox