Re: [PATCH 18/25] dynamic_debug: Introduce global fake module param $module.dyndbg

[Rusty Russell <rusty@rustcorp.com.au>]

On Wed, 7 Dec 2011 01:33:45 -0700, Jim Cromie <jim.cromie@gmail.com> wrote:
> On Tue, Dec 6, 2011 at 6:01 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
> > This worked out pretty neatly.  Thanks!
> 
> It did.  Almost like you planned it.

I do get lucky sometimes...

> >> -                   int (*unknown)(char *param, char *val));
> >> +                   int (*unknown)(char *param, char *val, const char *modname));
> >
> > Do you really want the modname here, or a struct module?  I wonder if we
> > should make this a standard opaque void *.  Of course, we'd have to
> > modify parse_args callers, but you're abusing "name" arg here a bit
> > anyway.
> >
> 
> I thought about the possible abuse, but then saw existing uses:
> 
> linux-2.6]$ grep parse_args init/main.c
> 	parse_args("early options", cmdline, NULL, 0, do_early_param);
> 	parse_args("Booting kernel", static_command_line, __start___param,
> 
> "Booting kernel" isnt quite a name either.
> 
> wrt using a struct module arg, Id prefer not.
> what I need is the name, so that the ddebug-queries being passed
> can leave out the module name and thus be shorter and less redundant

But from the module you can get the name.  It's just that having a
cb/void* pair is pretty standard practice.  Still, it's a line ball, and
I'm not unhappy enough to change it until we need it.

Thanks,
Rusty.