From: Rusty Russell <rusty@rustcorp.com.au>
To: Kevin Cernekee <cernekee@gmail.com>, "'Jan Beulich'" <JBeulich@suse.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/2] module: Fix performance regression on modules with large symbol tables
Date: Mon, 21 Nov 2011 15:36:11 +1030 [thread overview]
Message-ID: <87ipme9i9o.fsf@rustcorp.com.au> (raw)
In-Reply-To: <63fcc782681c8b3bd330164871ad4785@localhost>
On Thu, 17 Nov 2011 19:15:02 -0800, Kevin Cernekee <cernekee@gmail.com> wrote:
> Potential memory savings from reusing EXACT strtab matches: 36,475 bytes
> total; 35,432 from nvidia.ko. For comparison, discarding non-core
> strtab entries saved about 91KB on my system.
...
> Original scheme: 1.230s
> With patch V2: 0.280s
> With naive copying: 0.058s
I'm deeply tempted. It's very simple, 46 lines shorter, preserves exact
matches, and doesn't have any strange slowdowns on corner cases.
But like Kevin, I could be convinced either way. Jan?
Thanks,
Rusty.
next prev parent reply other threads:[~2011-11-21 5:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-13 3:08 [PATCH V2 1/2] module: Add comments describing how the "strmap" logic works Kevin Cernekee
2011-11-13 3:08 ` [PATCH V2 2/2] module: Fix performance regression on modules with large symbol tables Kevin Cernekee
2011-11-14 0:35 ` Rusty Russell
2011-11-14 8:48 ` Jan Beulich
2011-11-16 0:24 ` Rusty Russell
2011-11-18 3:15 ` Kevin Cernekee
2011-11-21 5:06 ` Rusty Russell [this message]
2011-11-21 6:29 ` Kevin Cernekee
2011-11-21 23:57 ` Rusty Russell
2011-11-21 8:08 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ipme9i9o.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=JBeulich@suse.com \
--cc=cernekee@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox