From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756495Ab0JSRGh (ORCPT ); Tue, 19 Oct 2010 13:06:37 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:64892 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755718Ab0JSRGf (ORCPT ); Tue, 19 Oct 2010 13:06:35 -0400 From: Kevin Hilman To: Anand Gadiyar Cc: Greg KH , Felipe Contreras , linux-usb@vger.kernel.org, linux-omap , linux-main , Felipe Balbi , Tony Lindgren Subject: Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff Organization: Deep Root Systems, LLC References: <1287482608-11320-1-git-send-email-felipe.contreras@gmail.com> <1287482608-11320-4-git-send-email-felipe.contreras@gmail.com> <20101019155219.GI4589@kroah.com> <4CBDC361.70507@ti.com> Date: Tue, 19 Oct 2010 10:06:33 -0700 In-Reply-To: <4CBDC361.70507@ti.com> (Anand Gadiyar's message of "Tue, 19 Oct 2010 21:42:17 +0530") Message-ID: <87iq0yxgbq.fsf@deeprootsystems.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Anand Gadiyar writes: > On 10/19/2010 9:22 PM, Greg KH wrote: >> On Tue, Oct 19, 2010 at 01:03:28PM +0300, Felipe Contreras wrote: >>> Add missing dependencies, and remove redundant ones, and select sensible >>> defaults. >>> >>> Signed-off-by: Felipe Contreras >>> --- >>> drivers/mfd/Kconfig | 3 ++- >>> drivers/regulator/Kconfig | 1 + >>> drivers/usb/gadget/Kconfig | 3 +-- >>> drivers/usb/musb/Kconfig | 6 ++---- >>> drivers/usb/otg/Kconfig | 2 ++ >>> 5 files changed, 8 insertions(+), 7 deletions(-) >>> >>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig >>> index db51ea1..0bbaf01 100644 >>> --- a/drivers/mfd/Kconfig >>> +++ b/drivers/mfd/Kconfig >>> @@ -156,6 +156,7 @@ config MENELAUS >>> config TWL4030_CORE >>> bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support" >>> depends on I2C=y&& GENERIC_HARDIRQS >>> + default y if ARCH_OMAP3 || ARCH_OMAP4 >> >> Sorry, but unless the driver is somehow required to keep the board from >> going up in a puff of smoke, a default should NEVER be y. >> >> Because of that, I can't take this patch. >> > > This is the driver for the Power-management IC on the board. Without > this IC being correctly configured, I'm guessing a lot of things will > fail. Not so sure if anything will go up in smoke (sounds unlikely), > or if the kernel will fail to boot - I'll check quickly - but for this > one specific instance, I think it's reasonable to accept a default y. > > Kevin/Tony can probably confirm. I don't thing the 'default y' should be done at this level. Instead, the boards/SoCs that have the hard requirement should do the 'select' Kevin