public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Jan Blunck <jblunck@novell.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Linux-Kernel Mailinglist <linux-kernel@vger.kernel.org>,
	linux-rt-users@vger.kernel.org,
	Sven-Thorsten Dietrich <sdietrich@novell.com>,
	Michael Galbraith <MGalbraith@novell.com>
Subject: Re: [RFC 3/4] Disable scheduler tick when we are running SCHED_FIFO tasks
Date: Wed, 08 Sep 2010 19:11:53 +0200	[thread overview]
Message-ID: <87iq2gw46e.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20100908142826.GI7436@bolzano.suse.de> (Jan Blunck's message of "Wed, 8 Sep 2010 16:28:26 +0200")

Jan Blunck <jblunck@novell.com> writes:

> On Wed, Sep 08, Peter Zijlstra wrote:
>
>> On Wed, 2010-09-08 at 14:29 +0200, Jan Blunck wrote:
>> > This patch is disabling the scheduler tick to go off when there is a task
>> > with SCHED_FIFO policy running. Since these tasks are not timesliced anyway
>> > we only care about timers, softirqs and such stuff just like when we disable
>> > the tick during idle periods.
>> > 
>> 
>> Also, doesn't this break any and all jiffies users?
>> 
>
> Sure. It was enough to make FTQ run.
>
>> And you need to restart the tick on call_rcu() and everything else that
>> requires the tick for processing.
>> 
>
> I realized that before as well but somehow forgot about it. Checking for a
> disabled timer tick on syscall entry would help. Like we do on irq entry as
> well.

That doesn't help the gettimeofday/clock_gettime vDSOs
which access jiffie like state in user space.

I guess you could force the vdso to call into the kernel
during such a region, but you cannot force it for an
process that is already context switched in this path
when the option is first enabled.

I guess it would work if you force all the vDSOs
to always do a system call at boot, but that's pretty
costly.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

  reply	other threads:[~2010-09-08 17:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-08 12:29 [RFC 0/4] Disable timer tick for SCHED_FIFO tasks Jan Blunck
2010-09-08 12:29 ` [RFC 1/4] ftrace: Add events for tracing timer interrupts Jan Blunck
2010-09-08 12:38   ` Peter Zijlstra
2010-09-08 13:24   ` Andi Kleen
2010-09-08 12:29 ` [RFC 2/4] ftrace: Add events for tracing tick start and stop Jan Blunck
2010-09-08 12:29 ` [RFC 3/4] Disable scheduler tick when we are running SCHED_FIFO tasks Jan Blunck
2010-09-08 12:43   ` Peter Zijlstra
2010-09-08 14:32     ` Jan Blunck
2010-09-08 12:45   ` Peter Zijlstra
2010-09-08 13:21     ` Thomas Gleixner
2010-09-08 14:28     ` Jan Blunck
2010-09-08 17:11       ` Andi Kleen [this message]
2010-09-08 13:25   ` Andi Kleen
2010-09-08 14:47     ` Jan Blunck
2010-09-08 12:29 ` [RFC 4/4] ftrace: Add argument to tick start/stop tracing Jan Blunck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iq2gw46e.fsf@basil.nowhere.org \
    --to=andi@firstfloor.org \
    --cc=MGalbraith@novell.com \
    --cc=jblunck@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=sdietrich@novell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox