public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: WANG Cong <xiyou.wangcong@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, Oskar Schirmer <os@emlix.com>
Subject: Re: [PATCH] add missing include in lib/rational.c
Date: Thu, 08 Oct 2009 16:39:37 +0800	[thread overview]
Message-ID: <87iqeqp9di.fsf@gmail.com> (raw)
In-Reply-To: <20091008075403.GE30719@pengutronix.de> (Sascha Hauer's message of "Thu, 8 Oct 2009 09:54:03 +0200")

Sascha Hauer <s.hauer@pengutronix.de> writes:

> Hi,
>
> Here is a little patch to fix a compiler warning
>
> fixes:
>
> lib/rational.c:62: warning: data definition has no type or storage class
> lib/rational.c:62: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
> lib/rational.c:62: warning: parameter names (without types) in function declaration
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Acked-by: WANG Cong <xiyou.wangcong@gmail.com>

> ---
>  lib/rational.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/lib/rational.c b/lib/rational.c
> index b3c099b..3ed247b 100644
> --- a/lib/rational.c
> +++ b/lib/rational.c
> @@ -7,6 +7,7 @@
>   */
>  
>  #include <linux/rational.h>
> +#include <linux/module.h>
>  
>  /*
>   * calculate best rational approximation for a given fraction
> -- 
> 1.6.4.3

  reply	other threads:[~2009-10-08  8:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-08  7:54 [PATCH] add missing include in lib/rational.c Sascha Hauer
2009-10-08  8:39 ` WANG Cong [this message]
2009-10-08 15:30 ` Oskar Schirmer
2009-12-22 16:11   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iqeqp9di.fsf@gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=os@emlix.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox