From: Andi Kleen <andi@firstfloor.org>
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Cc: "Andi Kleen" <ak@suse.de>,
"Andrew Morton" <akpm@linux-foundation.org>,
mingo@elte.hu, clameter@sgi.com, linux-kernel@vger.kernel.org,
"Yasunori Goto" <y-goto@jp.fujitsu.com>,
"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH] mm: fix boundary checking in free_bootmem_core
Date: 14 Mar 2008 12:58:44 +0100 [thread overview]
Message-ID: <87iqzp5xfv.fsf@basil.nowhere.org> (raw)
In-Reply-To: <86802c440803131522t3d038d39gbe8eb0d38ddcb634@mail.gmail.com>
"Yinghai Lu" <yhlu.kernel@gmail.com> writes:
>
> then i tried to reserve 64M or 128M RAM before that, and free that
> before gart/switotble try to allloc_bootmem under 4g.
Sounds like an incredible hack. There are far better ways to do that
for bootmem allocations. e.g. you can just specify a high enough "goal"
That is how swiotlb solves a similar problem (at least before my
mask allocator rewrite)
> > with your improved free_bootmem()
>
> using phys_to_nid()? it seems we only have that on x86_64.
pfn/page_to_nid() is generic afaik.
> also there is assumpation that reserve_bootmem_node, reserver_bootmem
> can not cross the nodes.
> I want to remove that constrient too.
Makes sense, but that will be much more work and should be all separated.
-Andi
next prev parent reply other threads:[~2008-03-14 11:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 1:01 [PATCH] mm: fix boundary checking in free_bootmem_core Yinghai Lu
2008-03-12 23:21 ` Yinghai Lu
2008-03-12 23:33 ` Andrew Morton
2008-03-13 1:11 ` Yinghai Lu
2008-03-13 1:22 ` Andrew Morton
2008-03-13 21:59 ` Andi Kleen
2008-03-13 22:22 ` Yinghai Lu
2008-03-14 11:58 ` Andi Kleen [this message]
2008-03-14 16:44 ` Yinghai Lu
2008-03-14 16:53 ` Andi Kleen
2008-03-14 17:36 ` Yinghai Lu
2008-03-21 19:44 ` Andrew Morton
2008-03-21 20:00 ` Ingo Molnar
2008-03-21 21:54 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iqzp5xfv.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=y-goto@jp.fujitsu.com \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox