From: Dmitriy Monakhov <dmonakhov@openvz.org>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: nobh_truncate_page question
Date: Thu, 08 Feb 2007 01:45:10 +0300 [thread overview]
Message-ID: <87iredh9jd.fsf@sw.ru> (raw)
Could some one please explain me what's happens with nobh_truncate_page?
int nobh_truncate_page(struct address_space *mapping, loff_t from)
{
........
if ((offset & (blocksize - 1)) == 0)
goto out;
ret = -ENOMEM;
page = grab_cache_page(mapping, index);
if (!page)
goto out;
to = (offset + blocksize) & ~(blocksize - 1);
ret = a_ops->prepare_write(NULL, page, offset, to);
<<<<< This prepare_write() not balanced by appropriate commit_write()
<<<<< Currently this not is fatal because this function used only
<<<<< by ext2 and jfs witch unbalanced prepare/commit operations
<<<<< not painful.
if (ret == 0) {
kaddr = kmap_atomic(page, KM_USER0);
memset(kaddr + offset, 0, PAGE_CACHE_SIZE - offset);
flush_dcache_page(page);
kunmap_atomic(kaddr, KM_USER0);
set_page_dirty(page);
}
unlock_page(page);
page_cache_release(page);
out:
return ret;
}
But we can't just call commit_write after all job done because this result in
i_size increasing till block end. Where are two possible solutions:
a) Call ->commit_write() and then restore i_size to old value.
b) Leave code as it is now, but add warning comment about prepare/commit
balance violation.
next reply other threads:[~2007-02-07 22:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-07 22:45 Dmitriy Monakhov [this message]
2007-02-08 2:11 ` nobh_truncate_page question Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iredh9jd.fsf@sw.ru \
--to=dmonakhov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox