Re: 2.6.12-rc2-mm3

Oleg Nesterov
2005-05-03T10:40:43Z

Andrew Morton wrote:
>
> Oleg Nesterov <oleg@tv-sign.ru> wrote:
> >
> > ...
> > Before this timer patch del_timer(pending_timer) worked as
> > a memory barrier for the caller, now it does not.
> >
>
> I wonder if we should still do this? It would seem to be a safer approach.
>
> (This barrier stuff continues to give me the creeps. Imagine being
> dependent upon accidental barriers in the add/del/mod_timer code. Ugh).

I can't judge. But if we added barriers now, it would be
very hard to remove them later. And I think it's not good
to have these barriers "just in case".

Oleg.