Re: [PATCH] ATA over Ethernet driver for 2.6.9 (with changes)

Jan-Benedict Glaw
2004-12-13T21:23:55Z

[-- Attachment #1: Type: text/plain, Size: 1490 bytes --]

On Mon, 2004-12-13 11:04:51 -0500, Ed L Cashin <ecashin@coraid.com>
wrote in message <87k6rmuqu4.fsf@coraid.com>:
[...]

Impressive list of changes. I'm thinking about implementing a userland
server for AoE. Is there a formal protocol specification available?
Though, I'd use the block driver's sources to reverse engineer it, but
for interoperability purposes, it would probably be better to start off
a specification than an implementation.

. o O (...and I'd love to get my hands on a real hardware device)

> diff -urNp linux-2.6.9/drivers/block/aoe/aoecmd.c linux-2.6.9-aoe/drivers/block/aoe/aoecmd.c
> --- linux-2.6.9/drivers/block/aoe/aoecmd.c 1969-12-31 19:00:00.000000000 -0500
> +++ linux-2.6.9-aoe/drivers/block/aoe/aoecmd.c 2004-12-13 10:53:19.000000000 -0500
> +static void
> +aoecmd_ata_rw(struct Aoedev *d, struct Frame *f)
> +{
[...]
> + if (d->flags & DEVFL_EXT) {
> + ah->aflags |= AOEAFL_EXT;
> + ah->lba4 = sector >>= 8;
> + ah->lba5 = sector >>= 8;
> + } else {
> + extbit = 0;
> + ah->lba3 &= 0x0f;
> + ah->lba3 |= 0xe0; /* LBA bit + obsolete 0xa0 */

This comment doesn't match it's code.

MfG, JBG

--
Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481 _ O _
"Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg _ _ O
fuer einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]