Re: [PATCH] Nfs lost locks

[Philippe Troin <phil@fifi.org>]

Marcelo Tosatti <marcelo.tosatti@cyclades.com> writes:

> On Tue, 24 Feb 2004, Philippe Troin wrote:
> 
> > Marcelo Tosatti <marcelo.tosatti@cyclades.com> writes:
> >
> > > On Fri, 20 Feb 2004, Philippe Troin wrote:
> > >
> > > > The NFS client is prone to loose locks on filesystems when the locking
> > > > process is killed with a signal. This has been discussed on the nfs
> > > > mailing list in these threads:
> > > >
> > > >   http://sourceforge.net/mailarchive/forum.php?thread_id=3213117&forum_id=4930
> > > >
> > > >   http://marc.theaimsgroup.com/?l=linux-nfs&m=107074045907620&w=2
> > > >
> > > > Marcelo, if the above links are not sufficient, please email back for
> > > > more details.
> > > >
> > > > The enclosed patch is from Trond, and it fixes the problem.
> > >
> > > Hi Philippe,
> > >
> > > It might be wise to wait for the patch to be in 2.6 first?
> > >
> > > Trond, what do you think?
> >
> > I do not know about the 2.6.x status, but Trond requested help with
> > pushing this patch to the kernel, mentionning he was very busy with
> > NFSv4.
> >
> > I personnaly think it fixes a serious problem with file locking on
> > NFS, but that's my assessment.
> 
> I also think it fixes a serious problem with file locking on NFS. What I
> dont think is that it has been extensively tested (I seen you stressed
> file locking with it for a couple of days, but thats not enough).
> 
> I feel that it needs to get tested on different setups.
> 
> If Trond is confident it works reliably, I will apply it right away.

For reference and posterity, 2.4.26 includes this patch.

Thanks to Marcelo and Trond.

Phil.