From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Michal Rokos <m.rokos@sh.cvut.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.0-test11] VFAT fix for UTF-8 and trailing dots
Date: Sun, 07 Dec 2003 06:02:47 +0900 [thread overview]
Message-ID: <87iskt8xs8.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20031206192919.GA31981@nightmare.sh.cvut.cz>
Michal Rokos <m.rokos@sh.cvut.cz> writes:
> I don't know... Functions in nls_base.c have specification the same as
> those from userspace (defined by ISO/ANSI C or UNIX98).
>
> Probably we should. This was meant as minimal patch.
>
> In case you'll be modifiing nls_base.c, please, decide whether this
> shouldn't be in...
>
>
> --- linux-2.6.0-test11/fs/nls/nls_base.c.old 2003-11-26 21:44:31.000000000 +0100
> +++ linux-2.6.0-test11/fs/nls/nls_base.c 2003-12-06 20:09:01.000000000 +0100
> @@ -99,6 +99,7 @@ utf8_mbstowcs(wchar_t *pwcs, const __u8
> }
> } else {
> *op++ = *ip++;
> + n--;
> }
> }
> return (op - pwcs);
> >
> > For example, utf8_mbstowcs(outbuf, outlen, inbuf, inlen);
> >
>
> I'd would propose uft8_mbsntowcs(outbuf, outlen, inbuf, inlen);
Whoops, sorry. You are right.
But I really like the interface like iconv() than this. And current
nls interfaces also...
Anyway, I think your patches fix some bugs right now.
I'll submit the your both patches.
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2003-12-06 21:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-06 8:55 [PATCH 2.6.0-test11] VFAT fix for UTF-8 and trailing dots Michal Rokos
2003-12-06 15:52 ` OGAWA Hirofumi
2003-12-06 19:29 ` Michal Rokos
2003-12-06 21:02 ` OGAWA Hirofumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iskt8xs8.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=m.rokos@sh.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox