public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: coreythomas@charter.net
To: David Hinds <dhinds@lahmed.Stanford.EDU>
Cc: Rasmus Andersen <rasmus@jaquet.dk>,
	Arjan van de Ven <arjan@fenrus.demon.nl>,
	linux-kernel@vger.kernel.org, dhinds@zen.stanford.edu,
	corey@world.std.com
Subject: Re: Compile error in drivers/ide/osb4.c in 240-t10p6
Date: 30 Oct 2000 05:40:34 -0500	[thread overview]
Message-ID: <87itqapq71.fsf@bobo.spike.home> (raw)
In-Reply-To: <20001029144822.B622@jaquet.dk> <m13psPR-000OXnC@amadeus.home.nl> <20001029231257.J625@jaquet.dk> <20001029183230.A29522@lahmed.stanford.edu>
In-Reply-To: David Hinds's message of "Sun, 29 Oct 2000 18:32:30 -0800"


ray_cs was imported to the kernel as one of the first test drivers by
Linus.  At the time, he wanted to get rid of the CardServices(function...)
interface and replace it with pcmcia_function calls.  It seems that
the correct fix would be to change pcmcia_request_irq to RequestIRQ
like all the other drivers use.  Or, change all the other drivers.  In
any case I know of no reason for ray_cs to be unique.


David Hinds <dhinds@lahmed.Stanford.EDU> writes:

> On Sun, Oct 29, 2000 at 11:12:57PM +0100, Rasmus Andersen wrote:
> > 
> > Thanks for the pointer. However my test build still barfs in the final
> > link phase because we (in t10p6) morphed drivers/pcmcia/cs.c::pcmcia_
> > request_irq into (the static) cs_request_irq. The rename part
> > broke the two other places in cs.c where pcmcia_request_irq was
> > referenced and the static part made its usage in drivers/net/pcmcia/
> > ray_cs.c a bit awkward.
> 
> It should be un-morphed back to the way it was.  It was an error that
> slipped into a patch I was preparing, because I was hand-editing the
> "diff" output to accommodate some changes between the kernel tree and
> the separate PCMCIA package.
> 
> -- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

      reply	other threads:[~2000-10-30 10:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-10-29 13:48 Compile error in drivers/ide/osb4.c in 240-t10p6 Rasmus Andersen
2000-10-29 13:22 ` Arjan van de Ven
2000-10-29 22:12   ` Rasmus Andersen
2000-10-30  1:09     ` Jeff Garzik
2000-10-30  2:32     ` David Hinds
2000-10-30 10:40       ` coreythomas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87itqapq71.fsf@bobo.spike.home \
    --to=coreythomas@charter.net \
    --cc=arjan@fenrus.demon.nl \
    --cc=corey@world.std.com \
    --cc=dhinds@lahmed.Stanford.EDU \
    --cc=dhinds@zen.stanford.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rasmus@jaquet.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox