From: Thomas Gleixner <tglx@kernel.org>
To: "Paul E. McKenney" <paulmck@kernel.org>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>
Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>,
linux-kernel@vger.kernel.org, kernel-team@meta.com,
"Paul E. McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH RFC 1/9] hrtimer: Mark data-racy accesses to hrtimer_sleeper ->task field
Date: Tue, 11 Aug 2026 15:35:27 +0200 [thread overview]
Message-ID: <87jypwn5k0.ffs@fw13> (raw)
In-Reply-To: <20260731004019.3530210-1-paulmck@kernel.org>
On Thu, Jul 30 2026 at 17:40, Paul E. McKenney wrote:
> static enum hrtimer_restart hrtimer_wakeup(struct hrtimer *timer)
> {
> struct hrtimer_sleeper *t = container_of(timer, struct hrtimer_sleeper, timer);
> - struct task_struct *task = t->task;
> + struct task_struct *task = hrtimer_sleeper_task_get(t);
>
> - t->task = NULL;
> + hrtimer_sleeper_task_set(t, NULL);
To be honest, I find these helper functions more confusing that
useful unless you make the task member private at the very end of the
series once everything is converted over.
If not, then what's wrong with a plain READ/WRITE_ONCE()?
Thanks,
tglx
next prev parent reply other threads:[~2026-08-11 13:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 0:39 [PATCH RFC 0/9] Fix data races on hrtimer_sleeper ->task field Paul E. McKenney
2026-07-31 0:40 ` [PATCH RFC 1/9] hrtimer: Mark data-racy accesses to " Paul E. McKenney
2026-08-04 17:25 ` Dmitry Ilvokhin
2026-08-11 13:35 ` Thomas Gleixner [this message]
2026-08-11 19:15 ` Paul E. McKenney
2026-07-31 0:40 ` [PATCH RFC 2/9] aio: Use accessor for " Paul E. McKenney
2026-07-31 12:32 ` Jan Kara
2026-07-31 12:57 ` Christian Brauner
2026-07-31 17:40 ` Paul E. McKenney
2026-07-31 0:40 ` [PATCH RFC 3/9] wait: " Paul E. McKenney
2026-07-31 0:40 ` [PATCH RFC 4/9] io-uring/rw: " Paul E. McKenney
2026-07-31 15:03 ` Jens Axboe
2026-07-31 17:42 ` Paul E. McKenney
2026-07-31 0:40 ` [PATCH RFC 5/9] futex: Use accessor for hrtimer_sleeper ->task field in waitwake.c Paul E. McKenney
2026-08-03 15:20 ` André Almeida
2026-08-04 17:29 ` Dmitry Ilvokhin
2026-07-31 0:40 ` [PATCH RFC 6/9] timers: Use accessor for hrtimer_sleeper ->task field in sleep_timeout.c Paul E. McKenney
2026-08-04 17:31 ` Dmitry Ilvokhin
2026-07-31 0:40 ` [PATCH RFC 7/9] net: pktgen: Use accessor for hrtimer_sleeper ->task field Paul E. McKenney
2026-07-31 0:40 ` [PATCH RFC 8/9] rtmutex: " Paul E. McKenney
2026-08-04 17:32 ` Dmitry Ilvokhin
2026-08-04 20:15 ` Paul E. McKenney
2026-07-31 0:40 ` [PATCH RFC 9/9] futex: Use accessor for hrtimer_sleeper ->task field in requeue Paul E. McKenney
2026-08-03 15:21 ` André Almeida
2026-08-03 15:45 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jypwn5k0.ffs@fw13 \
--to=tglx@kernel.org \
--cc=anna-maria@linutronix.de \
--cc=frederic@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).