From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1988237CD3C for ; Tue, 30 Jun 2026 09:00:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782810026; cv=none; b=Qki4azSdvTO6+pMUas+sec3AEnANUbN11+4rIRIgSSTmu96Y2d9fJzGmA51NJUfphI5QDA6B6hggEFSSuyRwuLrYW++DsfZKow24qgT0vlVnAZE5+nqX2IeTJcYhzTxMWFsn/bf7dBDq3946N9u92x393AL0sBGTdWG53rTjB9w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782810026; c=relaxed/simple; bh=kOe29cC4sJhOm3plC50LoMxQwm0D9HhrkW+nvEm8NGs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=bF57yvGk6jVd/oVQyuiZ10KMHwuFdhgIJsV8cGaANNjO4t7xq3LPxqTnswMumxMmVtgCstFj9ilcB1WoOkUxVSSAyQIp4qlW36x0e6sB5PLDMIaqjNqdPDLJNp9idKWLJ7S90Cs38WsZJOyXi78AK0899rNNxymHDCfDQ2Qd7U4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=iZrsH3kT; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=IM8PTSe2; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=KBYgwT7+; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=BxEi7nWk; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="iZrsH3kT"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="IM8PTSe2"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="KBYgwT7+"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="BxEi7nWk" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E60A975EBB; Tue, 30 Jun 2026 09:00:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1782810022; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f1+O2WCp9jiLEOwPjE3ABodaDR6p6VbAmBaUKVlsie4=; b=iZrsH3kTRWJTpx766NI8TyrOlLaLZ5VUcpBu9Sw2qc7AnRlqsosoY9Ec22mhvrKau5VJmw xbapFWkgnuVfHuzJ/4r/yGSDz2DQjAT4O6xHbJIUtSW3trZyZlXO6Q/SSlBF2ayYz45N// 2GOWNoYyzWYHS63EMHyjtUTt721Xz3s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1782810022; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f1+O2WCp9jiLEOwPjE3ABodaDR6p6VbAmBaUKVlsie4=; b=IM8PTSe2OkKMMoWMjgTQ340E2VkwrjgyfXp5dOhLnFKTagEEx8x+6x62mqdgzh4+l60B/x isjhVwngRxkFNYAg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KBYgwT7+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=BxEi7nWk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1782810021; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f1+O2WCp9jiLEOwPjE3ABodaDR6p6VbAmBaUKVlsie4=; b=KBYgwT7+TD3BYLgoovg7SP35qhm2ewzny4Il6Xukeu+VIfiyRXDKVgPwK9DnnF09DpYjZL MrOWbNGjQWQxt1e9rVAfIwkMIHOyG9N1K1Wd4q2tMpvN2ysritL3IOZc5A/Stf0+/1rdG+ hLyjex44IPDd68goH7fGx3vbKD+Oxl0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1782810021; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f1+O2WCp9jiLEOwPjE3ABodaDR6p6VbAmBaUKVlsie4=; b=BxEi7nWkG8C10rx5ci6JWPSnYQHaSNAWnOPMt9Dqkfmcu49Ou3P49hZRd8CZA3UlZ+iGkV BiS13sx6ctwTzLDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CE66A779A8; Tue, 30 Jun 2026 09:00:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id BiqfMKWFQ2oWNAAAD6G6ig (envelope-from ); Tue, 30 Jun 2026 09:00:21 +0000 From: Gabriel Krisman Bertazi To: Yi Xie , axboe@kernel.dk Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, Yi Xie Subject: Re: [PATCH] io_uring/memmap: return PTR_ERR() from get_unmapped_area() In-Reply-To: <20260630065700.97360-1-xieyi@kylinos.cn> Organization: SUSE References: <20260630065700.97360-1-xieyi@kylinos.cn> Date: Tue, 30 Jun 2026 05:00:20 -0400 Message-ID: <87jyrg5rob.fsf@mailhost.krisman.be> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Flag: NO X-Rspamd-Action: no action X-Spam-Level: X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; HAS_ORG_HEADER(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[mailhost.krisman.be:mid,suse.de:dkim,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: E60A975EBB X-Spam-Score: -4.51 Yi Xie writes: > Use PTR_ERR() on validate failure, like io_uring_mmap(). FWIW, this is not about using PTR_ERR, but about changing the return on error to -EINVAL, which is what is returned by io_uring_validate_mmap_request. The commit message should reflect that, specially because this is returned to userspace eventually, and might break some application checks.. > Signed-off-by: Yi Xie > --- > io_uring/memmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/io_uring/memmap.c b/io_uring/memmap.c > index da1f6c5d07f8..23e8a85111bc 100644 > --- a/io_uring/memmap.c > +++ b/io_uring/memmap.c > @@ -337,7 +337,7 @@ unsigned long io_uring_get_unmapped_area(struct file *filp, unsigned long addr, > > ptr = io_uring_validate_mmap_request(filp, pgoff); > if (IS_ERR(ptr)) > - return -ENOMEM; > + return PTR_ERR(ptr); > > /* > * Some architectures have strong cache aliasing requirements. > -- > 2.25.1 > -- Gabriel Krisman Bertazi