From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 153913F0AB6;
	Tue, 30 Jun 2026 14:46:48 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1782830809; cv=none; b=bmVVf34T2Cfd3p3AniN3pWpiQl8om7r+StSH9kYibMN62Pqta/uOP+5hva0QT52VrI6c2XD29gww4jqgQjY/ds+fLe2PE0NaRVBFcwSYT+DwW555OLUQ5cur0H0QbMwQFHnh8XNjSZnnQKxhTgeN526uexckX2BmDyno0JlPWpY=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1782830809; c=relaxed/simple;
	bh=DLIdamcxujGmprppFt9NtsCNxBtM/Us+m3JNK/blc2c=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:
	 MIME-Version:Content-Type; b=ogQV/pURByqvbzRJhwjc/v5yQ3pYNwUkBQ1+snErNpcorpmf1tU+QBRcf3pq3SwIK5N34wsGV+BP1IDOqYMxWqfhck3WXMvK1hVngF8FRH4OGYztVe0CcDBIHjWkkrPih1ynhufo+p5YtoJX5RvTt1HNOuNI8T4RVSU4F4y1gk4=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jcpfsMI0; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jcpfsMI0"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B7161F000E9;
	Tue, 30 Jun 2026 14:46:47 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1782830808;
	bh=j6OwDerxhRjXIaHh1FTuELXdWa9x8UdInRjOIqNsTNQ=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date;
	b=jcpfsMI0dql7IfEYZHk4tat9YX6F50U6Wvcrj3Lx2+aW5GFgJW8qepL1WWB8Ig+8G
	 OAw1PMVkWNJThwQiwi3sJeW1YwH9+Pa5EmKANzh/TUededsFiNI2ioyAGLwrZCwJdd
	 qlviuu/PmdGKUIGEfliMzrWVyJ2taoYbTKfEMwxZqc5nLqvqqfYSYMoNUeRJkilV4Z
	 VhRFGzUVl0ioU7SPAwfodyX5vM9Al6nkNytndXmKBKH7UJtTgU6XKa4Fobb6Tw1m18
	 fqxxerwBVfberfAWkgs2TLy+qi2AGWCi4hdG9SwDHdPgtbk5VImkr275PKRDDgsktd
	 SzbHczpJRcB3A==
From: Thomas Gleixner <tglx@kernel.org>
To: Maulik Shah <maulik.shah@oss.qualcomm.com>, Bjorn Andersson
 <andersson@kernel.org>, Konrad Dybcio <konradybcio@kernel.org>, Rob
 Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor
 Dooley <conor+dt@kernel.org>, Linus Walleij <linusw@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
 devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Sneh Mankad
 <sneh.mankad@oss.qualcomm.com>, Maulik Shah <maulik.shah@oss.qualcomm.com>
Subject: Re: [PATCH v3 2/8] irqchip/qcom-pdc: Move all statics to struct
 pdc_desc
In-Reply-To: <20260616-hamoa_pdc_v3-v3-2-4d8e1504ea75@oss.qualcomm.com>
References: <20260616-hamoa_pdc_v3-v3-0-4d8e1504ea75@oss.qualcomm.com>
 <20260616-hamoa_pdc_v3-v3-2-4d8e1504ea75@oss.qualcomm.com>
Date: Tue, 30 Jun 2026 16:46:45 +0200
Message-ID: <87jyrgqe5m.ffs@fw13>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain

On Tue, Jun 16 2026 at 14:55, Maulik Shah wrote:
> -		for (i = 0; i < pdc_region[n].cnt; i++)
> -			__pdc_enable_intr(i + pdc_region[n].pin_base, 0);
> +		for (int i = 0; i < pdc->region[n].cnt; i++)
> +			pdc->enable_intr(i + pdc->region[n].pin_base, 0);

This needs a guard(raw_spinlock_irqsave)() when invoking
pdc->enable_intr(). The probe function is only invoked
with interrupts disabled during early boot. If it's called later, then
this still works, but lockdep will be rightfully upset.