From: Thomas Gleixner <tglx@kernel.org>
To: Guixin Liu <kanie@linux.alibaba.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Marc Zyngier <maz@kernel.org>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Inochi Amaoto <inochiama@gmail.com>,
Nam Cao <namcao@linutronix.de>,
Shradha Gupta <shradhagupta@linux.microsoft.com>,
Randy Dunlap <rdunlap@infradead.org>
Cc: Xunlei Pang <xlpang@linux.alibaba.com>,
oliver.yang@linux.alibaba.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/2] genirq/msi: Introduce update hwsize helper
Date: Wed, 25 Mar 2026 09:15:42 +0100 [thread overview]
Message-ID: <87jyv0fhox.ffs@tglx> (raw)
In-Reply-To: <20260324014754.4973-2-kanie@linux.alibaba.com>
On Tue, Mar 24 2026 at 09:47, Guixin Liu wrote:
> +int msi_domain_update_hwsize(struct device *dev, unsigned int domid,
> + unsigned int hwsize_new)
> +{
> + struct msi_domain_info *info;
> + struct irq_domain *domain;
> +
> + if (hwsize_new > MSI_XA_DOMAIN_SIZE)
> + return -EINVAL;
> + if (!hwsize_new)
> + hwsize_new = MSI_XA_DOMAIN_SIZE;
> +
> + domain = msi_get_device_domain(dev, domid);
> + if (!domain)
> + return -ENODEV;
> +
> + info = domain->host_data;
> + if (hwsize_new != info->hwsize)
> + info->hwsize = hwsize_new;
This is incorrect because the underlying irqdomain has been created with
the original hardware size. So just fiddling with info->hwsize results
in inconsistent state.
next prev parent reply other threads:[~2026-03-25 8:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 1:47 [PATCH 0/2] Update MSI-X irq domain hwsize Guixin Liu
2026-03-24 1:47 ` [PATCH 1/2] genirq/msi: Introduce update hwsize helper Guixin Liu
2026-03-25 8:15 ` Thomas Gleixner [this message]
2026-03-25 8:49 ` Guixin Liu
2026-03-24 1:47 ` [PATCH 2/2] PCI/MSI: Update MSI-X irq domain hwsize Guixin Liu
2026-03-24 13:59 ` Thomas Gleixner
2026-03-25 1:34 ` Guixin Liu
2026-03-25 7:42 ` Thomas Gleixner
2026-03-25 8:40 ` Guixin Liu
2026-03-25 13:58 ` Thomas Gleixner
2026-03-26 1:55 ` Guixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jyv0fhox.ffs@tglx \
--to=tglx@kernel.org \
--cc=bhelgaas@google.com \
--cc=inochiama@gmail.com \
--cc=jonathan.cameron@huawei.com \
--cc=kanie@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=maz@kernel.org \
--cc=namcao@linutronix.de \
--cc=oliver.yang@linux.alibaba.com \
--cc=rdunlap@infradead.org \
--cc=shradhagupta@linux.microsoft.com \
--cc=xlpang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox