From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id B57FF282F16
	for <linux-kernel@vger.kernel.org>; Fri, 20 Mar 2026 13:35:46 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1774013746; cv=none; b=TlPXPkaEUVIJnPZHl3I5jkrn/sYe83mVp3ZIzrXv0VfLAM3caQVBJkk7BXNwoP8d9KO2+wVZ21D97gLgMMj9bpGX9BdhA3hkNM6/qG5EXGH0LDQjfHQKe0PlZefxFIawU7c/OGoA6U1SSUwQcUiNg7scjdw59Gcm3ywsxBaXabE=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1774013746; c=relaxed/simple;
	bh=e80gbV9mt05SfdLSdPMkLi5uD5XvvL9lzz/PDXanG1g=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:
	 MIME-Version:Content-Type; b=vBquWo3qPV2bm+R/7aGradpEj0Wlp/adp4GAeFp7PbYZGUjtK29MRP7UOG2BtpX5CFshCKetL71/l4suefBawMPAy9m4ovXQFKJLR7CdHakaw7MPy32aBUG9RGjYIXnGCR/YgP7yF1AgNyMt/xpaxQleUJZYSvpT0XUzIQCbfHQ=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HSPI64KN; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HSPI64KN"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 371F7C2BCB0;
	Fri, 20 Mar 2026 13:35:44 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1774013746;
	bh=e80gbV9mt05SfdLSdPMkLi5uD5XvvL9lzz/PDXanG1g=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
	b=HSPI64KNDE9vB7nTrZBIHWwXbQ2bcm3SEcfzU5KK39n6SPBei9KGE5cSt8Vpd2BSC
	 G5Sh61nz2QFcy+KKRnNG3SCp6v48hRCWLjFVSGluWABsI/pitUakoDyvFmzDK34/32
	 E50Kg99dZhtRHK0NIeXgfqy8fNKEdcD8ZCQvkC0rKZwjl0wG12B9ml0lc8uMrCnyJA
	 vpWW/a4ASSWJgXyXkAXEP0iFHcDYz/vnXjeQu2tMTzY5JynzIVxNVE8GmajMvniAy2
	 +GOjfo9D0YaYXl5fQ5iDukg4r9pHo94TdrWZKT6jS/eMWi7MeAushTWmU0ChN0kCBZ
	 FuBB/uGnMDrXQ==
From: Thomas Gleixner <tglx@kernel.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, =?utf-8?Q?Andr?=
 =?utf-8?Q?=C3=A9?= Almeida
 <andrealmeid@igalia.com>, Sebastian Andrzej Siewior
 <bigeasy@linutronix.de>, Carlos O'Donell <carlos@redhat.com>, Peter
 Zijlstra <peterz@infradead.org>, Florian Weimer <fweimer@redhat.com>, Rich
 Felker <dalias@aerifal.cx>, Torvald Riegel <triegel@redhat.com>, Darren
 Hart <dvhart@infradead.org>, Ingo Molnar <mingo@kernel.org>, Davidlohr
 Bueso <dave@stgolabs.net>, Arnd Bergmann <arnd@arndb.de>, "Liam R .
 Howlett" <Liam.Howlett@oracle.com>, Uros Bizjak <ubizjak@gmail.com>,
 Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
Subject: Re: [patch v2 09/11] futex: Provide infrastructure to plug the non
 contended robust futex unlock race
In-Reply-To: <20260319231239.749930268@kernel.org>
References: <20260319225224.853416463@kernel.org>
 <20260319231239.749930268@kernel.org>
Date: Fri, 20 Mar 2026 14:35:42 +0100
Message-ID: <87jyv6k4i9.ffs@tglx>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain

On Fri, Mar 20 2026 at 00:24, Thomas Gleixner wrote:
> +#ifdef CONFIG_FUTEX_ROBUST_UNLOCK
> +void __futex_fixup_robust_unlock(struct pt_regs *regs, struct futex_unlock_cs_range *csr)
> +{
> +	void __user *pop = arch_futex_robust_unlock_get_pop(regs);
> +
> +	if (!pop)
> +		return;
> +
> +	futex_robust_list_clear_pending(pop, csr->cs_pop_size32 ? FLAGS_ROBUST_LIST32 : 0);

That needs to be 

	futex_robust_list_clear_pending(pop, csr->pop_size32 ? FLAGS_ROBUST_LIST32 : 0);

Somehow that fixup was lost on the devel machine. Fixed in the git tree.

Thanks,

        tglx