From: Thomas Gleixner <tglx@kernel.org>
To: Biju <biju.das.au@gmail.com>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Biju Das <biju.das.au@gmail.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v4 4/9] irqchip/renesas-rzg2l: Drop IRQC_NUM_IRQ macro
Date: Wed, 11 Mar 2026 10:06:34 +0100 [thread overview]
Message-ID: <87jyvirazp.ffs@tglx> (raw)
In-Reply-To: <20260227140316.308106-5-biju.das.jz@bp.renesas.com>
On Fri, Feb 27 2026 at 14:03, Biju wrote:
> @@ -136,7 +145,7 @@ static void rzg2l_irqc_eoi(struct irq_data *d)
> raw_spin_lock(&priv->lock);
> if (hw_irq >= IRQC_IRQ_START && hw_irq <= IRQC_IRQ_COUNT)
> rzg2l_clear_irq_int(priv, hw_irq);
> - else if (hw_irq >= IRQC_TINT_START && hw_irq < IRQC_NUM_IRQ)
> + else if (hw_irq >= IRQC_TINT_START && hw_irq < priv->info.num_irq)
> rzg2l_clear_tint_int(priv, hw_irq);
As I pointed out in the review of the RZV2H driver:
https://lore.kernel.org/all/87ecmavbs0.ffs@tglx/
this really begs for separate interrupt chips so that the decision is
made at setup time and not at every interrupt delivery in the hotpath.
Aren't you guys working together?
Thanks,
tglx
next prev parent reply other threads:[~2026-03-11 9:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 14:03 [PATCH v4 0/9] Add RZ/G3L IRQC support Biju
2026-02-27 14:03 ` [PATCH v4 1/9] dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Use pattern for interrupt-names Biju
2026-02-27 14:03 ` [PATCH v4 2/9] dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Document RZ/G3L SoC Biju
2026-02-27 14:03 ` [PATCH v4 3/9] irqchip/renesas-rzg2l: Dynamically allocate fwspec array Biju
2026-02-27 14:03 ` [PATCH v4 4/9] irqchip/renesas-rzg2l: Drop IRQC_NUM_IRQ macro Biju
2026-03-11 9:06 ` Thomas Gleixner [this message]
2026-03-11 9:19 ` Biju Das
2026-02-27 14:03 ` [PATCH v4 5/9] irqchip/renesas-rzg2l: Drop IRQC_TINT_START macro Biju
2026-02-27 14:03 ` [PATCH v4 6/9] irqchip/renesas-rzg2l: Drop IRQC_IRQ_COUNT macro Biju
2026-02-27 14:03 ` [PATCH v4 7/9] irqchip/renesas-rzg2l: Add RZ/G3L support Biju
2026-02-27 14:03 ` [PATCH v4 8/9] irqchip/renesas-rzg2l: Add shared interrupt support Biju
2026-02-27 14:03 ` [PATCH v4 9/9] arm64: dts: renesas: r9a08g046: Add ICU node Biju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jyvirazp.ffs@tglx \
--to=tglx@kernel.org \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox