From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Gabor Juhos <j4g8y7@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Gabor Juhos <j4g8y7@gmail.com>
Subject: Re: [PATCH] arm64: dts: marvell: armada-37xx: align 'phy-names' of EHCI node with DT schema
Date: Mon, 02 Mar 2026 16:45:18 +0100 [thread overview]
Message-ID: <87jyvufd69.fsf@BLaptop.bootlin.com> (raw)
In-Reply-To: <20260220-armada-37xx-fix-ehci-phy-name-v1-1-27c9907aab8e@gmail.com>
Gabor Juhos <j4g8y7@gmail.com> writes:
> According to the 'generic-ehci.yaml' schema, the name of the first phy
> in an EHCI node must be "usb", however the 'usb@5e000' node in the
> 'armada-37xx.dtsi' uses "usb2-utmi-host-phy" instead.
>
> This causes dtbs_check warnings like the following ones:
>
> arch/arm64/boot/dts/marvell/armada-3720-atlas-v5.dtb: usb@5e000 (marvell,armada-3700-ehci): phy-names:0: 'usb' was expected
> from schema $id: http://devicetree.org/schemas/usb/generic-ehci.yaml
> arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@5e000 (marvell,armada-3700-ehci): phy-names:0: 'usb' was expected
> from schema $id: http://devicetree.org/schemas/usb/generic-ehci.yaml
> arch/arm64/boot/dts/marvell/armada-3720-eDPU.dtb: usb@5e000 (marvell,armada-3700-ehci): phy-names:0: 'usb' was expected
> from schema $id: http://devicetree.org/schemas/usb/generic-ehci.yaml
> ...
>
> Use "usb" as a name for the phy to avoid the warnings.
>
> No functional change, the USB interface works after the change:
>
> [ 1.472393] orion-ehci d005e000.usb: EHCI Host Controller
> [ 1.477847] orion-ehci d005e000.usb: new USB bus registered, assigned bus number 1
> [ 1.487127] orion-ehci d005e000.usb: irq 40, io mem 0xd005e000
> [ 1.505759] orion-ehci d005e000.usb: USB 2.0 started, EHCI 1.00
> [ 1.512493] hub 1-0:1.0: USB hub found
> [ 1.516434] hub 1-0:1.0: 1 port detected
> ...
> [ 4.175746] usb 1-1: new high-speed USB device number 2 using orion-ehci
> [ 4.347643] usb-storage 1-1:1.0: USB Mass Storage device detected
> [ 4.359972] scsi host0: usb-storage 1-1:1.0
> [ 5.367100] scsi 0:0:0:0: Direct-Access ADATA USB Flash Drive 1.00 PQ: 0 ANSI: 6
> [ 5.387091] sd 0:0:0:0: [sda] 30869504 512-byte logical blocks: (15.8 GB/14.7 GiB)
> [ 5.398420] sd 0:0:0:0: [sda] Write Protect is off
> [ 5.408108] sd 0:0:0:0: [sda] Write cache: disabled, read cache: disabled, doesn't support DPO or FUA
> [ 5.477359] sda: sda1
> [ 5.480037] sd 0:0:0:0: [sda] Attached SCSI removable disk
>
> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> index 87f9367aec1227c2c6de52f358d51bcff758c147..a8d10e4de81619c44ccbe0f08e69707dc28005a3 100644
> --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> @@ -396,7 +396,7 @@ usb2: usb@5e000 {
> marvell,usb-misc-reg = <&usb2_syscon>;
> interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
> phys = <&usb2_utmi_host_phy>;
> - phy-names = "usb2-utmi-host-phy";
> + phy-names = "usb";
> status = "disabled";
> };
>
>
> ---
> base-commit: fcaf733ca526b69595ed1d227e2cc59ddd24eff7
> change-id: 20260217-armada-37xx-fix-ehci-phy-name-cdfc108b2473
>
> Best regards,
> --
> Gabor Juhos <j4g8y7@gmail.com>
>
--
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2026-03-02 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 10:03 [PATCH] arm64: dts: marvell: armada-37xx: align 'phy-names' of EHCI node with DT schema Gabor Juhos
2026-03-02 15:45 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jyvufd69.fsf@BLaptop.bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j4g8y7@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox