Re: [PATCH 04/15] dmaengine: dw: dmamux: fix OF node leak on route allocation failure

Johan Hovold
2025-11-18T09:21:35Z

On Mon, Nov 17, 2025 at 06:05:47PM +0100, Andy Shevchenko wrote:
> On Mon, Nov 17, 2025 at 05:12:47PM +0100, Johan Hovold wrote:
> > Make sure to drop the reference taken to the DMA master OF node also on
> > late route allocation failures.
>
> ...
>
> > +put_dma_spec_np:
> > + of_node_put(dma_spec->np);
>
> Can we use __free() instead?

I'm no fan of __free() but here it's a particularly bad fit, so no.

Johan