From: Andreas Hindborg <a.hindborg@kernel.org>
To: Alice Ryhl <aliceryhl@google.com>, Lyude Paul <lyude@redhat.com>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
"FUJITA Tomonori" <fujita.tomonori@gmail.com>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Anna-Maria Behnsen" <anna-maria@linutronix.de>,
"John Stultz" <jstultz@google.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"open list:DELAY, SLEEP, TIMEKEEPING,
TIMERS [RUST]" <rust-for-linux@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 6/7] rust: time: Add Instant::from_ktime()
Date: Tue, 26 Aug 2025 10:20:56 +0200 [thread overview]
Message-ID: <87jz2qwl1z.fsf@t14s.mail-host-address-is-not-set> (raw)
In-Reply-To: <CAH5fLgggbF2KWHazQ9rDeyVEjxg4LipfXA1qepPAhkkaHD4Mxw@mail.gmail.com>
"Alice Ryhl" <aliceryhl@google.com> writes:
> On Thu, Aug 21, 2025 at 9:34 PM Lyude Paul <lyude@redhat.com> wrote:
>>
<cut>
>
>> + #[inline]
>> + pub(crate) unsafe fn from_ktime(ktime: bindings::ktime_t) -> Self {
>> + debug_assert!(ktime >= 0);
>
> If you're going to have a debug assertion, perhaps it would make sense
> to check both bounds?
The upper bound is bindings::ktime_t::MAX, so it would be a useless check.
Best regards,
Andreas Hindborg
next prev parent reply other threads:[~2025-08-26 8:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250821193259.964504-1-lyude@redhat.com>
2025-08-21 19:32 ` [PATCH v9 1/7] rust: hrtimer: Document the return value for HrTimerHandle::cancel() Lyude Paul
2025-08-21 19:32 ` [PATCH v9 2/7] rust: hrtimer: Add HrTimerInstant Lyude Paul
2025-08-21 19:32 ` [PATCH v9 3/7] rust: hrtimer: Add HrTimer::raw_forward() and forward() Lyude Paul
2025-08-21 19:32 ` [PATCH v9 4/7] rust: hrtimer: Add HrTimerCallbackContext and ::forward() Lyude Paul
2025-08-21 19:32 ` [PATCH v9 5/7] rust: hrtimer: Add forward_now() to HrTimer and HrTimerCallbackContext Lyude Paul
2025-08-21 19:32 ` [PATCH v9 6/7] rust: time: Add Instant::from_ktime() Lyude Paul
2025-08-21 23:10 ` FUJITA Tomonori
2025-08-22 7:46 ` Alice Ryhl
2025-08-26 8:20 ` Andreas Hindborg [this message]
2025-08-26 8:45 ` Andreas Hindborg
2025-08-21 19:32 ` [PATCH v9 7/7] rust: hrtimer: Add HrTimer::expires() Lyude Paul
2025-08-26 8:43 ` Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jz2qwl1z.fsf@t14s.mail-host-address-is-not-set \
--to=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=anna-maria@linutronix.de \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=frederic@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).