Re: [PATCH RFC] rust: HrTimerMode replacement with bitfield_options macro

Miguel Ojeda
2025-01-28T18:55:17Z

On Tue, Jan 28, 2025 at 6:13 PM Timothy Garwood via B4 Relay
<devnull+gtimothy-dev.protonmail.com@kernel.org> wrote:
>
> This patch provides an example of usage of the bitfield_options macro
> proposed in [1] as a replacement for the HrTimerMode enum introduced in
> [2].
> [1] is a RFC.
> This patch depends on both [1] and [2]

This is great, that is exactly what I was thinking about, and
showcases the advantage indeed :)

One quick question: what happens with the generated docs of the enum
and each variant etc.? (since that is part of the savings in lines
here)

Nits/tips: when you send the next version, consider sending both as a
series, i.e. this patch being #2 in the series, and #1 the one the
"real patch" that introduces the macro. That way they stay linked and
people browsing their emails and/or Lore will see it together :)

Also, the notes on the commit that are not part of the commit should
go after the SoB and the `---` line, before the diffstat.

There is also some strange text wrapping going on in the message, e.g.
on the `Link:` lines.

Cheers,
Miguel