[PATCH] ALSA: hda/realtek: Fix noise from speakers on Lenovo IdeaPad 3 15IAU7

[PATCH] ALSA: hda/realtek: Fix noise from speakers on Lenovo IdeaPad 3 15IAU7

[Parsa Poorshikhian]

Fixes: 70794b9563fe ("ALSA: hda/realtek: Add more codec ID to no shutup pins list")
Fix noise from speakers connected to AUX port when no sound is playing.
The problem occurs because the `alc_shutup_pins` function includes
a 0x10ec0257 vendor ID, which causes noise on Lenovo IdeaPad 3 15IAU7 with
Realtek ALC257 codec when no sound is playing.
Removing this vendor ID from the function fixes the bug.

Signed-off-by: Parsa Poorshikhian <parsa.poorsh@gmail.com>
---
 sound/pci/hda/patch_realtek.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index e2dbcf8f5bcf..7b593642da99 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -583,7 +583,6 @@ static void alc_shutup_pins(struct hda_codec *codec)
 	switch (codec->core.vendor_id) {
 	case 0x10ec0236:
 	case 0x10ec0256:
-	case 0x10ec0257:
 	case 0x19e58326:
 	case 0x10ec0283:
 	case 0x10ec0285:
-- 
2.45.2

forgot to CC all relevant maintainers

[Parsa Poorshikhian]

i forgot to CC all relevant maintainers in previous patch email, so this
reply would CC them. sorry for the inconvenience. this is my first time
doing merge request in linux.

Signed-off-by: Parsa Poorshikhian <parsa.poorsh@gmail.com>

Re: forgot to CC all relevant maintainers

[Takashi Iwai]

On Sat, 10 Aug 2024 00:17:56 +0200,
Parsa Poorshikhian wrote:
> 
> i forgot to CC all relevant maintainers in previous patch email, so this
> reply would CC them. sorry for the inconvenience. this is my first time
> doing merge request in linux.
> 
> Signed-off-by: Parsa Poorshikhian <parsa.poorsh@gmail.com>

I'm not sure which exact patch you're referring to.

Could you rather just resubmit your patch with your proper
Signed-off-by tag?


thanks,

Takashi