From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 656D713B2A9 for ; Tue, 25 Jun 2024 12:31:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719318673; cv=none; b=oEy42pMXZDr86aRflB4Hnaim51xsaZ5Wi0aQWYEWm/KgxUpb/6ekYUZbxgaruesP6NGhHWnHgpbokiIjhidcdc6xPItiu565UhfYJbgboH4zx3Mf+IfvK866THyKedGeHXN1xpTPkt8uIcfmt1qS8+LVMsCW9oqnY6h2tQogXXY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719318673; c=relaxed/simple; bh=PeHagsxKzjxwLdWOV4lkwGNCbtPK2Ze0OFmXyLu4q34=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=QeFP+LLNVSrwtMTiwBu2Ci2XWbHqdiS0CSunSI7aV8xDrAqrm3U12yIuZZXYwO5PQB489/rQesZVf0SWY3kdsIvfaewPkKoQtnEs+lxSvcsXl8lw3zvwFZjy/yu3gjPXq/00McCeaRAXS3FPuoimVGaSEcSWnlTnbU+NJOnjNZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=UBFeK08P; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=kxXP1j8e; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="UBFeK08P"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="kxXP1j8e" From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1719318668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Akgk/QsPgStwF9UJyy8HLB4YhLw0hiLKSouqo01a4jo=; b=UBFeK08PiEF5Mqm5uuXyIm2TyAKUQMESNTCPPkjk4kxDe4fYP3NLBJkHyDKaJoN6fs9Fid nGUPHpa63lZjFzyj7O5BZsz1umvB+oiohjyQjcJqPVCOZLyCBZoinWV8vfo854YRANFLkq p/l7e9n1QCFatu+ZSeO+fHs6CoSa1B3trB49fp8NBhsSxO056QZCb69UeNUk15xDcvtmWc +8PJOkS2W7rjLt76QZAYtd78AknEjTpEqb5fteCH3zPBYh0vc8Pe2UxEYGv/I5GEhInqlS DXbrP1HJzbBGqqbuLqL9aKe4NMuWTKaPSq5GsP0TpJh8ZXE3LFA481gv25U6jQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1719318668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Akgk/QsPgStwF9UJyy8HLB4YhLw0hiLKSouqo01a4jo=; b=kxXP1j8eZNTyr+NgvS7TSgDqTV2e/j4sQNBDtiCkDbKdtZGscX8n7shIFjb7bH3ctRqbyA OXw+mZgbJy4GvaBA== To: Xin Li , Hou Wenlong , linux-kernel@vger.kernel.org Cc: Lai Jiangshan , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Xin Li , Jacob Pan , Rick Edgecombe , Paolo Bonzini Subject: Re: [PATCH 1/2] x86/fred: Always install system interrupt handler into IDT In-Reply-To: References: <2f632ef59c8c9cc27c3702bc2d286496ed298d65.1718972598.git.houwenlong.hwl@antgroup.com> Date: Tue, 25 Jun 2024 14:31:08 +0200 Message-ID: <87jzid5hmb.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Tue, Jun 25 2024 at 02:19, Xin Li wrote: > On 6/21/2024 6:12 AM, Hou Wenlong wrote: >> diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h >> index d4f24499b256..daee9f7765bc 100644 >> --- a/arch/x86/include/asm/idtentry.h >> +++ b/arch/x86/include/asm/idtentry.h >> @@ -470,8 +470,7 @@ static inline void fred_install_sysvec(unsigned int vector, const idtentry_t fun >> #define sysvec_install(vector, function) { \ >> if (cpu_feature_enabled(X86_FEATURE_FRED)) \ >> fred_install_sysvec(vector, function); \ >> - else \ >> - idt_install_sysvec(vector, asm_##function); \ > > empty line, it improves readability. > > And please put a comment here to explain why this is unconditionally > done for IDT. Wait. If we need this during early boot, then why don't we enable FRED earlier? Thanks, tglx