From: Thomas Gleixner <tglx@linutronix.de>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Anna-Maria Behnsen <anna-maria@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tick: shift tick_nohz_switch_to_nohz() from tick_check_oneshot_change() to hrtimer_run_queues()
Date: Mon, 03 Jun 2024 10:14:40 +0200 [thread overview]
Message-ID: <87jzj6789b.ffs@tglx> (raw)
In-Reply-To: <20240602102007.GA27454@redhat.com>
On Sun, Jun 02 2024 at 12:20, Oleg Nesterov wrote:
> @@ -1891,8 +1891,11 @@ void hrtimer_run_queues(void)
> * there only sets the check bit in the tick_oneshot code,
> * otherwise we might deadlock vs. xtime_lock.
> */
> - if (tick_check_oneshot_change(!hrtimer_is_hres_enabled())) {
> - hrtimer_switch_to_hres();
> + if (tick_check_oneshot_change()) {
> + if (hrtimer_is_hres_enabled())
> + hrtimer_switch_to_hres();
> + else
> + tick_nohz_switch_to_nohz();
hrtimers have no business with tick_nohz_switch_to_nohz(),
really. That's a strict tick/nohz specific thing. hrtimers do not care
about NOHZ much. They care about whether they can switch to high
resolution mode.
Thanks,
tglx
next prev parent reply other threads:[~2024-06-03 8:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 12:42 [PATCH] tick: shift tick_nohz_switch_to_nohz() from tick_check_oneshot_change() to hrtimer_run_queues() Oleg Nesterov
2024-05-30 15:24 ` Frederic Weisbecker
2024-05-30 17:12 ` Oleg Nesterov
2024-06-01 14:56 ` Oleg Nesterov
2024-05-31 0:28 ` kernel test robot
2024-05-31 1:21 ` kernel test robot
2024-06-02 10:20 ` [PATCH v2] " Oleg Nesterov
2024-06-03 8:14 ` Thomas Gleixner [this message]
2024-06-03 13:41 ` Oleg Nesterov
2024-06-03 15:03 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzj6789b.ffs@tglx \
--to=tglx@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox